Bug 143379 - fast/fixed-layout/fixed-layout.html is flaky
Summary: fast/fixed-layout/fixed-layout.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-03 09:33 PDT by Alexey Proskuryakov
Modified: 2015-04-06 09:11 PDT (History)
8 users (show)

See Also:


Attachments
Patch (3.43 KB, patch)
2015-04-03 14:42 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-04-03 09:33:03 PDT
fast/fixed-layout/fixed-layout.html is flaky on EWS and Mac bots, seems to always fail elsewhere, and even to break subsequent tests.

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Ffixed-layout%2Ffixed-layout.html
Comment 1 Alexey Proskuryakov 2015-04-03 09:35:52 PDT
See also http://trac.webkit.org/changeset/182311

Not sure if we should roll out <http://trac.webkit.org/changeset/182307>. I'm going to mark the test as flaky in root test expectations, keep it skipped where it's skipped, and wait to Tim to weigh in.
Comment 2 Alexey Proskuryakov 2015-04-03 09:39:02 PDT
Added an expectation in r182319.
Comment 3 Tim Horton 2015-04-03 12:55:43 PDT
run-webkit-tests --repeat-each=100 --fully-parallel fast/fixed-layout

reproduces the flakiness quite reliably for me
Comment 4 Tim Horton 2015-04-03 14:42:27 PDT
Created attachment 250098 [details]
Patch
Comment 5 Tim Horton 2015-04-03 17:09:00 PDT
http://trac.webkit.org/changeset/182339
Comment 6 Alexey Proskuryakov 2015-04-03 21:54:06 PDT
On Windows, the test started to time out after this patch, and it seems to have started to crash on Gtk:

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Ffixed-layout%2Ffixed-layout.html
Comment 7 Tim Horton 2015-04-03 23:39:19 PDT
(In reply to comment #6)
> On Windows, the test started to time out after this patch, and it seems to
> have started to crash on Gtk:
> 
> https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=fast%2Ffixed-layout%2Ffixed-layout.html

GTK makes "fixed layout" mean a lot more than it should, and in really bad ways (randomly setting prefs in random places, etc.), so I've mostly been disregarding them.  Should probably skip the test there. Windows is more interesting.