Bug 143378 – Move Mac-specific ruby tests to platform/mac

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Myles C. Maxfield]

Move Mac-specific ruby tests to platform/mac

[Myles C. Maxfield]

Created attachment 250080 [details]
Patch

[Brent Fulgham]

Comment on attachment 250080 [details]
Patch

Did you use "svn mv" on these files? It doesn't look like it, which means we will lose the (brief) history of the test files.

[Build Bot]

Comment on attachment 250080 [details]
Patch

Attachment 250080 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5544167048478720

New failing tests:
platform/mac/fast/ruby/ruby-expansion-cjk-5.html
platform/mac/fast/ruby/ruby-expansion-cjk-2.html
platform/mac/fast/ruby/ruby-expansion-cjk-3.html
platform/mac/fast/ruby/ruby-expansion-cjk.html
platform/mac/fast/ruby/ruby-expansion-cjk-4.html

[Build Bot]

Created attachment 250087 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Brent Fulgham]

(In reply to comment #4)
> Created attachment 250087 [details]
> Archive of layout-test-results from ews101 for mac-mavericks
> 
> The attached test failures were seen while running run-webkit-tests on the
> mac-ews.
> Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Are these tests only valid on Yosemite or newer? Might need to be skipped in platform/mac-yosemite...

[Brent Fulgham]

(In reply to comment #5)
> (In reply to comment #4)
> > Created attachment 250087 [details]
> > Archive of layout-test-results from ews101 for mac-mavericks
> > 
> > The attached test failures were seen while running run-webkit-tests on the
> > mac-ews.
> > Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
> 
> Are these tests only valid on Yosemite or newer? Might need to be skipped in
> platform/mac-yosemite...

... I mean "platform/mac-mavericks".

[Build Bot]

Comment on attachment 250080 [details]
Patch

Attachment 250080 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6312195449159680

New failing tests:
platform/mac/fast/ruby/ruby-expansion-cjk-5.html
platform/mac/fast/ruby/ruby-expansion-cjk-2.html
platform/mac/fast/ruby/ruby-expansion-cjk-3.html
platform/mac/fast/ruby/ruby-expansion-cjk.html
platform/mac/fast/ruby/ruby-expansion-cjk-4.html

[Build Bot]

Created attachment 250088 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Alexey Proskuryakov]

In fact, I'd prefer to not have any tests in platform directories, that's super confusing. I think that we should only have results there.

[Myles C. Maxfield]

The tests should work on both Mac platforms. I'll have to figure out why they're not.

Currently I don't believe there is a way to make reftests look for expected results in platform directories. That's why I had to move the tests themselves.

[Alexey Proskuryakov]

You don't have to move the tests, you can just add expectations for other platforms (skip or failure, whichever is more appropriate).

[Myles C. Maxfield]

(In reply to comment #11)
> You don't have to move the tests, you can just add expectations for other
> platforms (skip or failure, whichever is more appropriate).

That is the current state. Sounds like I should do nothing.

[Daniel Bates]

For completeness, we moved the the ruby tests from LayoutTests/fast/ruby to LayoutTests/platform/mac in <http://trac.webkit.org/changeset/184899> (bug #145336).