Bug 143361 – Fix the EFL and GTK build after r182243

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

See https://bugs.webkit.org/show_bug.cgi?id=143293#c12 for details.
The clean build is still broken. :(

[Zan Dobersek]

I'll produce something.

[Zan Dobersek]

Created attachment 250058 [details]
Patch

[WebKit Commit Bot]

Attachment 250058 [details] did not pass style-queue:


ERROR: Source/WebKit2/PlatformGTK.cmake:425:  There should be exactly one empty line instead of 0 between ""        <file alias=\"images/panIcon\">panIcon.png</file>\n"" and ""        <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n"".  [list/emptyline] [5]
ERROR: Source/WebKit2/PlatformGTK.cmake:426:  Alphabetical sorting problem. ""        <file alias=\"images/textAreaResizeCorner@2x\">[e-mail]</file>\n"" should be before ""        <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n"".  [list/order] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Zan Dobersek]

(In reply to comment #2)
> Created attachment 250058 [details]
> Patch

Fixes clean builds for the GTK port. EFL fix is speculative, so please test it out.

[Csaba Osztrogonác]

(In reply to comment #4)
> (In reply to comment #2)
> > Created attachment 250058 [details]
> > Patch
> 
> Fixes clean builds for the GTK port. EFL fix is speculative, so please test
> it out.

Thanks for the fix, I'll check it immediately.

[Csaba Osztrogonác]

Comment on attachment 250058 [details]
Patch

It works on EFL too, so r=me.

[Zan Dobersek]

Comment on attachment 250058 [details]
Patch

Clearing flags on attachment: 250058

Committed r182315: <http://trac.webkit.org/changeset/182315>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.

[Gyuyoung Kim]

Comment on attachment 250058 [details]
Patch

Thank you for the fix !