Bug 143353 - Some elements missing from fullscreen media controls
Summary: Some elements missing from fullscreen media controls
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-02 17:04 PDT by Roger Fong
Modified: 2015-09-14 10:53 PDT (History)
5 users (show)

See Also:

Attachments
patch (3.22 KB, patch)
2015-04-02 17:12 PDT, Roger Fong 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (611.80 KB, application/zip)
2015-04-02 17:42 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (561.50 KB, application/zip)
2015-04-02 18:05 PDT, Build Bot 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-04-02 17:04:16 PDT 
Sometimes there are missing elements from the fullscreen controls.
This includes the fullscreen exit button and the status display.
Comment 1 Roger Fong 2015-04-02 17:06:36 PDT 
rdar://problem/20143218
Comment 2 Roger Fong 2015-04-02 17:12:05 PDT 
Created attachment 250022 [details]
patch
Comment 3 Roger Fong 2015-04-02 17:19:21 PDT 
Note: hasVisualMedia was only used for the purpose of determining whether or not the fullscreen button is hidden...
Comment 4 Build Bot 2015-04-02 17:42:28 PDT 
Comment on attachment 250022 [details]
patch

Attachment 250022 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4922848489504768

New failing tests:
media/audio-as-video-fullscreen.html
Comment 5 Build Bot 2015-04-02 17:42:31 PDT 
Created attachment 250024 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 6 Roger Fong 2015-04-02 18:00:29 PDT 
(In reply to comment #3)
> Note: hasVisualMedia was only used for the purpose of determining whether or
> not the fullscreen button is hidden...

Oh I see, the purpose of hasVisualMedia was to distinguish with the audio controls, not as a way of determining whether or not content had been loaded.
Will fix.
Comment 7 Build Bot 2015-04-02 18:05:10 PDT 
Comment on attachment 250022 [details]
patch

Attachment 250022 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5473272170807296

New failing tests:
media/audio-as-video-fullscreen.html
Comment 8 Build Bot 2015-04-02 18:05:14 PDT 
Created attachment 250027 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 9 Roger Fong 2015-04-02 18:50:47 PDT 
On second thought why do we even support an audio format in a video element?
That's not in the W3C spec and should generate an error.
Comment 10 Eric Carlson 2015-04-03 08:46:45 PDT 
(In reply to comment #9)
> On second thought why do we even support an audio format in a video element?
> That's not in the W3C spec and should generate an error.

It is perfectly legal to have an audio-only file in a <video> element, or a file with audio and video (and text) in an <audio> element.
Comment 11 Roger Fong 2015-05-26 17:22:34 PDT 
No longer valid.
Comment 12 Csaba Osztrogonác 2015-09-14 10:53:15 PDT 
Comment on attachment 250022 [details]
patch

Cleared review? from attachment 250022 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).