Bug 143349 – Add Options::dumpSourceAtDFGTime()

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Sometimes, we will want to see the JSC source code that we're compiling, and it would be nice to be able to do this without having to jump thru a lot of hoops.  So, let's add a Options::dumpSourceAtDFGTime() option just like we have a Options::dumpBytecodeAtDFGTime() option.

[Mark Lam]

(In reply to comment #0)
> Sometimes, we will want to see the JSC source code ...

typo: ... want to see the JS source code ...

[Mark Lam]

Created attachment 250014 [details]
the patch.

[Michael Saboff]

Comment on attachment 250014 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=250014&action=review

r=me

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:3988
> +        dataLog("==== begin source ====\n");

Do we this this delimiter?

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:3990
> +        dataLog("\n==== end source ====\n\n");

ditto

[Mark Lam]

(In reply to comment #3)
> Comment on attachment 250014 [details]
> the patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250014&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:3988
> > +        dataLog("==== begin source ====\n");
> 
> Do we this this delimiter?
> 
> > Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:3990
> > +        dataLog("\n==== end source ====\n\n");
> 
> ditto

It helps.  Consider the case where we actually compile eval or global code which don't have a { } around them.  Plus this is only debugging code.  So, let's go with these for now.

[Mark Lam]

Thanks for the review.  Landed in r182294: <http://trac.webkit.org/r182294>.