Bug 143348 – [WK2][NetworkCache] Drop HTTP method from NetworkCache::Key

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Drop HTTP method from NetworkCache::Key as we only cache GET responses for now. Even when we start caching HEAD responses, we likely will not want the method to be part of the key because:
- A HEAD response can be used to update the headers of a previously cached response to GET
- A cached GET response may be used to satisfy subsequent HEAD requests

[Chris Dumez]

Created attachment 250013 [details]
Patch

[Antti Koivisto]

Comment on attachment 250013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=250013&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.h:80
> -    static const unsigned version = 2;
> +    static const unsigned version = 3;

You shouldn't do this. The old entries will get cleaned during normal cache shrinks (and in an unlikely event of hash collision will fail to validate). Version updates are meant to be used when the directory structure changes and be paired with code that deletes the old directory structure.

[Antti Koivisto]

It could be renamed to diskLayoutVersion or something similarly informative.

[Chris Dumez]

Committed r182296: <http://trac.webkit.org/changeset/182296>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 143448

[Chris Dumez]

Created attachment 257979 [details]
Patch

[Chris Dumez]

We can land again now that efficacy logging has been disabled.

[WebKit Commit Bot]

Comment on attachment 257979 [details]
Patch

Clearing flags on attachment: 257979

Committed r187698: <http://trac.webkit.org/changeset/187698>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.