Bug 143325 – [Content Extensions] Only add unique universal action locations.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Alex Christensen]

Right now we have waaaay too many actions on the DFA root.  That's slowing things down a lot.

[Alex Christensen]

Created attachment 249954 [details]
Patch

[Benjamin Poulain]

Comment on attachment 249954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249954&action=review

> Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:151
>  

You could take the opportunity to remove that blank line.

[Alex Christensen]

http://trac.webkit.org/changeset/182265

[Darin Adler]

Comment on attachment 249954 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249954&action=review

> Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:136
> +    HashSet<uint64_t> universalActionLocations;

HashSet won’t work with 0 nor will it work with the maximum value. Do we have a guarantee that actionLocationAndFlags will never have either of those values?

[Alexey Proskuryakov]

This patch made a test assert: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcontentextensions%2Fwhitelist.html

ASSERT(!HashTranslator::equal(KeyTraits::emptyValue(), key));

Looks like Darin's comment is spot on.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 143338

[Alex Christensen]

I forgot the HashTraits :(

The value can be 0, so I used UnsignedWithZeroKeyHashTraits.  We only use the lowest 48 bits of the uint64_t, so it will never be the maximum 2 values.

http://trac.webkit.org/changeset/182283