RESOLVED FIXED 143308
[WinCairo] Link errors, unresolved texture mapper methods. 
https://bugs.webkit.org/show_bug.cgi?id=143308
Summary [WinCairo] Link errors, unresolved texture mapper methods.
peavo
Reported 2015-04-01 09:32:09 PDT
We need to add some new texture mapper files to the project.
Attachments
Patch (14.52 KB, patch)
2015-04-01 09:39 PDT, peavo 		no flags
DetailsFormatted DiffDiff
Patch (13.98 KB, patch)
2015-04-01 10:37 PDT, peavo 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2015-04-01 09:39:25 PDT
Created attachment 249925 [details] Patch
Brent Fulgham
Comment 2 2015-04-01 09:59:11 PDT
Comment on attachment 249925 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249925&action=review > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:1 > +<?xml version="1.0" encoding="utf-8"?> Looks like we're introducing some UTF byte order markers. This shouldn't be needed for UTF8 formatted files. Could this file be saved as plain text before landing? > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:1 > +<?xml version="1.0" encoding="utf-8"?> Ditto the BOM here. Just save as plain UTF8.
Alex Christensen
Comment 3 2015-04-01 10:33:06 PDT
Comment on attachment 249925 [details] Patch I'll land this manually.
Alex Christensen
Comment 4 2015-04-01 10:33:47 PDT
http://trac.webkit.org/changeset/182237
peavo
Comment 5 2015-04-01 10:37:51 PDT
Reopening to attach new patch.
peavo
Comment 6 2015-04-01 10:37:55 PDT
Created attachment 249932 [details] Patch
peavo
Comment 7 2015-04-01 10:39:14 PDT
(In reply to comment #3) > Comment on attachment 249925 [details] > Patch > > I'll land this manually. Sorry, I didn't see this, thanks for reviewing :)
Alex Christensen
Comment 8 2015-04-01 10:39:54 PDT
Comment on attachment 249932 [details] Patch This is what I landed.
peavo
Comment 9 2015-04-01 10:44:34 PDT
(In reply to comment #8) > Comment on attachment 249932 [details] > Patch > > This is what I landed. Thanks :)
Note You need to log in before you can comment on or make changes to this bug.