Bug 143308 - [WinCairo] Link errors, unresolved texture mapper methods.
Summary: [WinCairo] Link errors, unresolved texture mapper methods.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-01 09:32 PDT by peavo
Modified: 2015-04-01 10:44 PDT (History)
2 users (show)

See Also:

Attachments
Patch (14.52 KB, patch)
2015-04-01 09:39 PDT, peavo 		no flags Details | Formatted Diff | Diff
Patch (13.98 KB, patch)
2015-04-01 10:37 PDT, peavo 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-04-01 09:32:09 PDT 
We need to add some new texture mapper files to the project.
Comment 1 peavo 2015-04-01 09:39:25 PDT 
Created attachment 249925 [details]
Patch
Comment 2 Brent Fulgham 2015-04-01 09:59:11 PDT 
Comment on attachment 249925 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249925&action=review

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:1
> +<?xml version="1.0" encoding="utf-8"?>

Looks like we're introducing some UTF byte order markers. This shouldn't be needed for UTF8 formatted files. Could this file be saved as plain text before landing?

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:1
> +<?xml version="1.0" encoding="utf-8"?>

Ditto the BOM here. Just save as plain UTF8.
Comment 3 Alex Christensen 2015-04-01 10:33:06 PDT 
Comment on attachment 249925 [details]
Patch

I'll land this manually.
Comment 4 Alex Christensen 2015-04-01 10:33:47 PDT 
http://trac.webkit.org/changeset/182237
Comment 5 peavo 2015-04-01 10:37:51 PDT 
Reopening to attach new patch.
Comment 6 peavo 2015-04-01 10:37:55 PDT 
Created attachment 249932 [details]
Patch
Comment 7 peavo 2015-04-01 10:39:14 PDT 
(In reply to comment #3)
> Comment on attachment 249925 [details]
> Patch
> 
> I'll land this manually.

Sorry, I didn't see this, thanks for reviewing :)
Comment 8 Alex Christensen 2015-04-01 10:39:54 PDT 
Comment on attachment 249932 [details]
Patch

This is what I landed.
Comment 9 peavo 2015-04-01 10:44:34 PDT 
(In reply to comment #8)
> Comment on attachment 249932 [details]
> Patch
> 
> This is what I landed.

Thanks :)