Bug 143302 - Use modern loops in WebProcess
Summary: Use modern loops in WebProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hunseop Jeong
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-04-01 04:47 PDT by Hunseop Jeong
Modified: 2015-04-10 01:13 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.10 KB, patch)
2015-04-01 04:51 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Patch (8.14 KB, patch)
2015-04-01 06:27 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Thanks for review, I changed the code to follow your comments. (7.83 KB, patch)
2015-04-06 20:51 PDT, Hunseop Jeong 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hunseop Jeong 2015-04-01 04:47:02 PDT 
Use modern range for-loops in WebProcess.
Comment 1 Hunseop Jeong 2015-04-01 04:51:57 PDT 
Created attachment 249913 [details]
Patch
Comment 2 Hunseop Jeong 2015-04-01 06:27:10 PDT 
Created attachment 249917 [details]
Patch
Comment 3 Darin Adler 2015-04-06 18:35:57 PDT 
Comment on attachment 249917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249917&action=review

> Source/WebKit2/WebProcess/WebProcess.cpp:542
> +        if (page.get()->windowAndWebPageAreFocused())

This should just be page-> rather than page.get()->

> Source/WebKit2/WebProcess/WebProcess.cpp:1146
> -            page->unmarkAllMisspellings();
> +            page.get()->unmarkAllMisspellings();

This change should not be needed.

> Source/WebKit2/WebProcess/WebProcess.cpp:1148
> -            page->unmarkAllBadGrammar();
> +            page.get()->unmarkAllBadGrammar();

This change should not be needed.

> Source/WebKit2/WebProcess/WebProcess.cpp:1219
> +        if (Frame* mainFrame = page.get()->mainFrame())

This should be page-> rather than page.get()->
Comment 4 Hunseop Jeong 2015-04-06 20:51:21 PDT 
Created attachment 250253 [details]
Thanks for review, I changed the code to follow your comments.
Comment 5 Darin Adler 2015-04-09 22:19:33 PDT 
Comment on attachment 250253 [details]
Thanks for review, I changed the code to follow your comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=250253&action=review

> Source/WebKit2/WebProcess/WebProcess.cpp:312
> +    for (auto& scheme : parameters.urlSchemesRegistererdAsEmptyDocument)

After we land this patch we should fix the "Registererd" typo (not just here, but everywhere).
Comment 6 WebKit Commit Bot 2015-04-09 23:08:53 PDT 
Comment on attachment 250253 [details]
Thanks for review, I changed the code to follow your comments.

Clearing flags on attachment: 250253

Committed r182622: <http://trac.webkit.org/changeset/182622>
Comment 7 WebKit Commit Bot 2015-04-09 23:09:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Hunseop Jeong 2015-04-10 01:13:40 PDT 
(In reply to comment #5)
> Comment on attachment 250253 [details]
> Thanks for review, I changed the code to follow your comments.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250253&action=review
> 
> > Source/WebKit2/WebProcess/WebProcess.cpp:312
> > +    for (auto& scheme : parameters.urlSchemesRegistererdAsEmptyDocument)
> 
> After we land this patch we should fix the "Registererd" typo (not just
> here, but everywhere).

I fixed the typos( urlSchemesRegistererdAsEmptyDocument 
                -> urlSchemesRegisteredAsEmptyDocument)
https://bugs.webkit.org/show_bug.cgi?id=143598