Bug 143302 – Use modern loops in WebProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Hunseop Jeong]

Use modern range for-loops in WebProcess.

[Hunseop Jeong]

Created attachment 249913 [details]
Patch

[Hunseop Jeong]

Created attachment 249917 [details]
Patch

[Darin Adler]

Comment on attachment 249917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249917&action=review

> Source/WebKit2/WebProcess/WebProcess.cpp:542
> +        if (page.get()->windowAndWebPageAreFocused())

This should just be page-> rather than page.get()->

> Source/WebKit2/WebProcess/WebProcess.cpp:1146
> -            page->unmarkAllMisspellings();
> +            page.get()->unmarkAllMisspellings();

This change should not be needed.

> Source/WebKit2/WebProcess/WebProcess.cpp:1148
> -            page->unmarkAllBadGrammar();
> +            page.get()->unmarkAllBadGrammar();

This change should not be needed.

> Source/WebKit2/WebProcess/WebProcess.cpp:1219
> +        if (Frame* mainFrame = page.get()->mainFrame())

This should be page-> rather than page.get()->

[Hunseop Jeong]

Created attachment 250253 [details]
Thanks for review, I changed the code to follow your comments.

[Darin Adler]

Comment on attachment 250253 [details]
Thanks for review, I changed the code to follow your comments.

View in context: https://bugs.webkit.org/attachment.cgi?id=250253&action=review

> Source/WebKit2/WebProcess/WebProcess.cpp:312
> +    for (auto& scheme : parameters.urlSchemesRegistererdAsEmptyDocument)

After we land this patch we should fix the "Registererd" typo (not just here, but everywhere).

[WebKit Commit Bot]

Comment on attachment 250253 [details]
Thanks for review, I changed the code to follow your comments.

Clearing flags on attachment: 250253

Committed r182622: <http://trac.webkit.org/changeset/182622>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Hunseop Jeong]

(In reply to comment #5)
> Comment on attachment 250253 [details]
> Thanks for review, I changed the code to follow your comments.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=250253&action=review
> 
> > Source/WebKit2/WebProcess/WebProcess.cpp:312
> > +    for (auto& scheme : parameters.urlSchemesRegistererdAsEmptyDocument)
> 
> After we land this patch we should fix the "Registererd" typo (not just
> here, but everywhere).

I fixed the typos( urlSchemesRegistererdAsEmptyDocument 
                -> urlSchemesRegisteredAsEmptyDocument)
https://bugs.webkit.org/show_bug.cgi?id=143598