Bug 143290 - Perf dashboard should have UI to test out anomaly detection strategies
Summary: Perf dashboard should have UI to test out anomaly detection strategies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 141443
  Show dependency tree / graph
 
Reported: 2015-03-31 20:25 PDT by Ryosuke Niwa
Modified: 2016-02-16 13:53 PST (History)
5 users (show)

See Also:

Attachments
Adds the feature (12.63 KB, patch)
2015-03-31 20:35 PDT, Ryosuke Niwa 		benjamin: review+
Details | Formatted Diff | Diff
Sample screenshot (209.93 KB, image/png)
2015-03-31 20:37 PDT, Ryosuke Niwa 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-03-31 20:25:29 PDT 
Add an UI to try out different kinds of anomaly detection strategies.
Comment 1 Ryosuke Niwa 2015-03-31 20:35:45 PDT 
Created attachment 249881 [details]
Adds the feature
Comment 2 Ryosuke Niwa 2015-03-31 20:37:35 PDT 
Created attachment 249882 [details]
Sample screenshot
Comment 3 Chris Dumez 2015-04-02 17:18:16 PDT 
Comment on attachment 249881 [details]
Adds the feature

rs=me
Comment 4 Benjamin Poulain 2015-04-02 17:19:37 PDT 
Comment on attachment 249881 [details]
Adds the feature

View in context: https://bugs.webkit.org/attachment.cgi?id=249881&action=review

> Websites/perf.webkit.org/public/v2/app.js:514
> +            anomalyDetectionStrategies, anomalies);

Weird to have those two on a new line.

> Websites/perf.webkit.org/public/v2/app.js:554
> +        for (var strategyIndex = 0; strategyIndex < anomalyDetectionStrategies.length; strategyIndex++) {

for...of ?

> Websites/perf.webkit.org/public/v2/app.js:566
> +                i++;

++i

> Websites/perf.webkit.org/public/v2/chart-pane.css:118
> +.stat-option input[type=number] {

I haaaaaaaate there is no better way select input elements. :)
Comment 5 Benjamin Poulain 2015-04-02 17:21:10 PDT 
Comment on attachment 249881 [details]
Adds the feature

rs=Chris
Comment 6 Ryosuke Niwa 2015-04-02 18:07:49 PDT 
Committed r182302: <http://trac.webkit.org/changeset/182302>