RESOLVED FIXED 143289
[iOS] Include Add to Reading List link action only where supported 
https://bugs.webkit.org/show_bug.cgi?id=143289
Summary [iOS] Include Add to Reading List link action only where supported
mitz
Reported 2015-03-31 20:09:55 PDT
<rdar://problem/20365675> The Add to Reading List link action should only be included in a link’s actions when the functionality is supported.
Attachments
Define and use HAVE_READING_LIST (6.59 KB, patch)
2015-03-31 20:52 PDT, mitz 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2015-03-31 20:52:52 PDT
Created attachment 249883 [details] Define and use HAVE_READING_LIST
Tim Horton
Comment 2 2015-03-31 21:02:05 PDT
Comment on attachment 249883 [details] Define and use HAVE_READING_LIST View in context: https://bugs.webkit.org/attachment.cgi?id=249883&action=review > Source/WebKit2/config.h:94 > +#define HAVE_READING_LIST 1 Should it not be HAVE_SAFARI_READING_LIST? This is very specifically about the Safari feature, yes?
mitz
Comment 3 2015-03-31 21:03:34 PDT
(In reply to comment #2) > Comment on attachment 249883 [details] > Define and use HAVE_READING_LIST > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249883&action=review > > > Source/WebKit2/config.h:94 > > +#define HAVE_READING_LIST 1 > > Should it not be HAVE_SAFARI_READING_LIST? This is very specifically about > the Safari feature, yes? Going to go with HAVE_SAFARI_SERVICES_FRAMEWORK. Thanks for the review!
mitz
Comment 4 2015-03-31 21:08:20 PDT
Fixed in <http://trac.webkit.org/r182219>.
Note You need to log in before you can comment on or make changes to this bug.