Bug 143289 - [iOS] Include Add to Reading List link action only where supported
Summary: [iOS] Include Add to Reading List link action only where supported
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-31 20:09 PDT by mitz
Modified: 2015-03-31 21:08 PDT (History)
2 users (show)

See Also:

Attachments
Define and use HAVE_READING_LIST (6.59 KB, patch)
2015-03-31 20:52 PDT, mitz 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2015-03-31 20:09:55 PDT 
<rdar://problem/20365675>

The Add to Reading List link action should only be included in a link’s actions when the functionality is supported.
Comment 1 mitz 2015-03-31 20:52:52 PDT 
Created attachment 249883 [details]
Define and use HAVE_READING_LIST
Comment 2 Tim Horton 2015-03-31 21:02:05 PDT 
Comment on attachment 249883 [details]
Define and use HAVE_READING_LIST

View in context: https://bugs.webkit.org/attachment.cgi?id=249883&action=review

> Source/WebKit2/config.h:94
> +#define HAVE_READING_LIST 1

Should it not be HAVE_SAFARI_READING_LIST? This is very specifically about the Safari feature, yes?
Comment 3 mitz 2015-03-31 21:03:34 PDT 
(In reply to comment #2)
> Comment on attachment 249883 [details]
> Define and use HAVE_READING_LIST
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249883&action=review
> 
> > Source/WebKit2/config.h:94
> > +#define HAVE_READING_LIST 1
> 
> Should it not be HAVE_SAFARI_READING_LIST? This is very specifically about
> the Safari feature, yes?

Going to go with HAVE_SAFARI_SERVICES_FRAMEWORK. Thanks for the review!
Comment 4 mitz 2015-03-31 21:08:20 PDT 
Fixed in <http://trac.webkit.org/r182219>.