Bug 143273 – Move ExpansionBehaviorFlags and TextDirection to their own file

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Move ExpansionBehaviorFlags and TextDirection to their own file

[Myles C. Maxfield]

Created attachment 249841 [details]
Patch

[WebKit Commit Bot]

Attachment 249841 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/text/TextHelpers.h:31:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 1 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 249841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249841&action=review

> Source/WebCore/platform/text/TextHelpers.h:27
> +#define TextHelpers_h

Not sure I like the name of this file. I'd expect a "helpers" file to contain a bunch of static functions that help me with text. This is more like TextFlags.h or TextRelatedEnums.h

> Source/WebCore/platform/text/TextHelpers.h:38
> +    ForbidLeadingExpansion = 0 << 1,

0 << anything is 0. Why not just say 0?

[Myles C. Maxfield]

Comment on attachment 249841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249841&action=review

>> Source/WebCore/platform/text/TextHelpers.h:27
>> +#define TextHelpers_h
> 
> Not sure I like the name of this file. I'd expect a "helpers" file to contain a bunch of static functions that help me with text. This is more like TextFlags.h or TextRelatedEnums.h

Done.

>> Source/WebCore/platform/text/TextHelpers.h:38
>> +    ForbidLeadingExpansion = 0 << 1,
> 
> 0 << anything is 0. Why not just say 0?

When this enum gets more complicated, it will be more obvious what is going on.

[Myles C. Maxfield]

Committed r182207: <http://trac.webkit.org/changeset/182207>