Bug 143264 – Fix the build on the WinCairo bot due to missing CoreFoundation.lib

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

LINK : fatal error LNK1181: cannot open input file 'CoreFoundation.lib' [C:\cygwin\home\webkitbot\win-cairo-release\build\Source\WTF\WTF.vcxproj\WTF.vcxproj]

[Brent Fulgham]

WinCairo shouldn't be trying to link to CoreFoundation.lib. It should be using CFLite.lib.

This seems like one of the build targets for WinCairo is using the Apple Windows variation.

[Csaba Osztrogonác]

Is there any plan to fix the WinCairo bot? It is still broken for a week.

(In reply to comment #2)
> Is there any plan to fix the WinCairo bot? It is still broken for a week.

It is strange that I don't see this error when compiling locally.
It is also strange that the log indicates that no WTF files are compiled, as if they are up to date, it seems to go straight to linking.

[Alex Christensen]

I took it down.  It's not uploading any useful information.  I'll fix it in the next few days.

[Csaba Osztrogonác]

(In reply to comment #4)
> I took it down.  It's not uploading any useful information.  I'll fix it in
> the next few days.

The bot is still down. It was green on 25th Mar last time. (~3 weeks before)
Is there anybody maintain the WinCairo bot and/or the port?

(In reply to comment #5)
> (In reply to comment #4)
> > I took it down.  It's not uploading any useful information.  I'll fix it in
> > the next few days.
> 
> The bot is still down. It was green on 25th Mar last time. (~3 weeks before)
> Is there anybody maintain the WinCairo bot and/or the port?

Yes, WinCairo is being maintained :)

[Alex Christensen]

And I intend to get a bot up and running this week.  Sorry it's taken so long.

[Csaba Osztrogonác]

(In reply to comment #7)
> And I intend to get a bot up and running this week.  Sorry it's taken so
> long.

The bot is still down, the latest green build was more than 5 weeks 
before, so I think we can consider the WinCairo bot unmaintained.

It's hard to take a port seriously, which doesn't have 
enough resource to maintain a buildbot on a _daily_ basis.

[Alex Christensen]

(In reply to comment #8)
> (In reply to comment #7)
> > And I intend to get a bot up and running this week.  Sorry it's taken so
> > long.
> 
> The bot is still down, the latest green build was more than 5 weeks 
> before, so I think we can consider the WinCairo bot unmaintained.
Sorry, I did not stick to my schedule.  I'm installing things on a Windows machine right now, which is unfortunately no trivial task.
> 
> It's hard to take a port seriously, which doesn't have 
> enough resource to maintain a buildbot on a _daily_ basis.
The way I see it, this is only a nuisance to those who are actively developing the WinCairo port.  I want these people to continue easily and I like to hack on WinCairo to compare with the AppleWin port and I want non-Apple companies to be able to use WebKit on Windows, so I maintain a buildbot, but unfortunately I've had some more urgent things recently.  I'll step it up a bit.

[Alex Christensen]

After http://trac.webkit.org/changeset/183521 I have a WinCairo bot that builds successfully.  I left the buildslave password and stuff at home, so it'll be up soon.

[Alex Christensen]

http://trac.webkit.org/changeset/183566 should have fixed this.

[Alex Christensen]

Now I'm seeing some errors like this:

Traceback (most recent call last):
    File "C:/Users/Alex/Documents/WinCairoBot/win-cairo-release/build/Source/JavaScriptCore/generate-js-builtins", line 283, in <module>
      os.rename(output_base + ".h.tmp", output_base + ".h")
  WindowsError: [Error 183] Cannot create a file when that file already exists

I'm uploading a fix for review.

[Alex Christensen]

Created attachment 251991 [details]
Patch

[Brent Fulgham]

Comment on attachment 251991 [details]
Patch

r=me

[Alex Christensen]

http://trac.webkit.org/changeset/183581

There are still a few places in the tests that try to call /usr/bin/env or similar commands, but it builds pretty reliably.  We'll get the tests to not require cygwin pretty soon, but it's already showing useful information about whether WinCairo builds or not.

Thanks!