Bug 143238 - [New Block-Inside-Inline Model] Make sure breaks occur both before and after the anonymous inline-block
Summary: [New Block-Inside-Inline Model] Make sure breaks occur both before and after ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-30 15:02 PDT by Dave Hyatt
Modified: 2015-03-31 11:21 PDT (History)
5 users (show)

See Also:

Attachments
Patch (17.18 KB, patch)
2015-03-30 15:08 PDT, Dave Hyatt 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2015-03-30 15:02:30 PDT 
Make sure line breaks occur both before and after the anonymous inline-block.
Comment 1 Dave Hyatt 2015-03-30 15:08:11 PDT 
Created attachment 249769 [details]
Patch
Comment 2 Dave Hyatt 2015-03-31 10:43:20 PDT 
Fixed in r182188.
Comment 3 Jon Lee 2015-03-31 11:21:58 PDT 
Comment on attachment 249769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249769&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:4118
> +                if (((canBreakReplacedElement && (autoWrap || oldAutoWrap) && (!isPrevChildInlineFlow || shouldBreakLineAfterText)) || clearPreviousFloat) || isAnonymousInlineBlock) {

is the extra parenthesis necessary? you've got ((...) || clearPreviousFloat || isAnonymousInlineBlock)