RESOLVED FIXED 143235
[Content Extensions] Correctly handle regular expressions matching everything 
https://bugs.webkit.org/show_bug.cgi?id=143235
Summary [Content Extensions] Correctly handle regular expressions matching everything
Alex Christensen
Reported 2015-03-30 13:23:20 PDT
There are lots of edge cases. They should be fixed and tested.
Attachments
Patch (24.29 KB, patch)
2015-03-30 13:36 PDT, Alex Christensen 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2015-03-30 13:36:03 PDT
Created attachment 249758 [details] Patch
Benjamin Poulain
Comment 2 2015-03-30 17:09:59 PDT
Comment on attachment 249758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249758&action=review > Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:61 > + for (unsigned i = 0; i < selectorLength; i++) { ++i > Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:62 > + actions.resize(actions.size() + sizeof(UChar)); Probably best doing this out of the loop. > Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:66 > + for (unsigned i = 0; i < selectorLength; i++) ++i > Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:89 > + selector.append(","); ','
Alex Christensen
Comment 3 2015-03-30 17:49:36 PDT
http://trac.webkit.org/changeset/182168
Note You need to log in before you can comment on or make changes to this bug.