There are lots of edge cases. They should be fixed and tested.
Created attachment 249758 [details] Patch
Comment on attachment 249758 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249758&action=review > Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:61 > + for (unsigned i = 0; i < selectorLength; i++) { ++i > Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:62 > + actions.resize(actions.size() + sizeof(UChar)); Probably best doing this out of the loop. > Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:66 > + for (unsigned i = 0; i < selectorLength; i++) ++i > Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:89 > + selector.append(","); ','
http://trac.webkit.org/changeset/182168