Bug 143234 – [iOS] WebContent crashing at WebCore: WebCore::Range::collectSelectionRects

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Enrica Casucci]

rdar://problem/18571345

[Enrica Casucci]

Created attachment 249754 [details]
Patch

[Tim Horton]

Comment on attachment 249754 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249754&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:137
> +        if (compositionRange)

Maybe we should pull this code into its own function so we can early return if !compositionRange (and then later if compositionRects.isEmpty()?)

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:141
>          if (compositionRects.size() > 1)

Will the plainTextReplacingNoBreakSpace a few lines below here handle a null compositionRange correctly?

[Enrica Casucci]

(In reply to comment #2)
> Comment on attachment 249754 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249754&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:137
> > +        if (compositionRange)
> 
> Maybe we should pull this code into its own function so we can early return
> if !compositionRange (and then later if compositionRects.isEmpty()?)
> 
> > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:141
> >          if (compositionRects.size() > 1)
> 
> Will the plainTextReplacingNoBreakSpace a few lines below here handle a null
> compositionRange correctly?

Yes it does. But I agree that there is no need to do any of the rest of the composition code if compositionRange is null.

[Enrica Casucci]

Committed revision 182162.