Bug 143231 - WebBackForwardList doesn't need to manually clear the snapshot of an entry when removing it.
Summary: WebBackForwardList doesn't need to manually clear the snapshot of an entry wh...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on: 143250
Blocks:
  Show dependency tree / graph
 
Reported: 2015-03-30 11:11 PDT by Andreas Kling
Modified: 2015-03-30 20:24 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.46 KB, patch)
2015-03-30 11:12 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-03-30 11:11:41 PDT 
No need to setSnapshot(nullptr) when removing an item from the WebBackForwardList now that items actually get destroyed right after.
Comment 1 Andreas Kling 2015-03-30 11:12:06 PDT 
Created attachment 249748 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-30 20:03:29 PDT 
Comment on attachment 249748 [details]
Patch

Clearing flags on attachment: 249748

Committed r182172: <http://trac.webkit.org/changeset/182172>
Comment 3 WebKit Commit Bot 2015-03-30 20:03:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 mitz 2015-03-30 20:09:36 PDT 
Isn’t WebBackForwardListItem an API object? A client may hold on to arbitrarily many instances but will have no way to get to the snapshots. This suggests that dropping the reference to the snapshot once the item is not in the list could still be beneficial.
Comment 5 Andreas Kling 2015-03-30 20:21:07 PDT 
(In reply to comment #4)
> Isn’t WebBackForwardListItem an API object? A client may hold on to
> arbitrarily many instances but will have no way to get to the snapshots.
> This suggests that dropping the reference to the snapshot once the item is
> not in the list could still be beneficial.

Oh! I did not realize that WebBackForwardListItem was exposed through the modern WebKit API. Rolling this out.
Comment 6 WebKit Commit Bot 2015-03-30 20:24:21 PDT 
Re-opened since this is blocked by bug 143250