Bug 143216 - [GStreamer] More GL shared context fixes
Summary: [GStreamer] More GL shared context fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-30 05:13 PDT by Philippe Normand
Modified: 2015-03-30 08:23 PDT (History)
4 users (show)

See Also:

Attachments
patch (4.82 KB, patch)
2015-03-30 05:20 PDT, Philippe Normand 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2015-03-30 05:13:42 PDT 
The patch from Bug 143049 has various incorrect changes.
Comment 1 Philippe Normand 2015-03-30 05:20:36 PDT 
Created attachment 249721 [details]
patch
Comment 2 Martin Robinson 2015-03-30 08:17:05 PDT 
Comment on attachment 249721 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249721&action=review

Looks good apart from the a naming nit:

> Source/WebCore/platform/graphics/glx/GLContextGLX.h:52
> +    virtual bool isEGLCompliant() const { return false; }

A context isn't really "EGL compliant" it's either an EGL context or something else. I recommend just calling this method "isEGLContext."
Comment 3 Philippe Normand 2015-03-30 08:23:23 PDT 
Committed r182139: <http://trac.webkit.org/changeset/182139>