WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 143207
Start the features.json files
https://bugs.webkit.org/show_bug.cgi?id=143207
Summary
Start the features.json files
Benjamin Poulain
Reported
2015-03-29 20:16:25 PDT
Start the features.json files
Attachments
Patch
(9.30 KB, patch)
2015-03-29 20:18 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2015-03-29 20:18:10 PDT
Created
attachment 249708
[details]
Patch
WebKit Commit Bot
Comment 2
2015-03-30 00:21:31 PDT
Comment on
attachment 249708
[details]
Patch Clearing flags on attachment: 249708 Committed
r182134
: <
http://trac.webkit.org/changeset/182134
>
WebKit Commit Bot
Comment 3
2015-03-30 00:21:35 PDT
All reviewed patches have been landed. Closing bug.
Timothy Hatcher
Comment 4
2015-03-31 11:55:36 PDT
Comment on
attachment 249708
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=249708&action=review
> Source/JavaScriptCore/features.json:42 > + "enabled-by-default": true
Symbol is disabled by default right now because of a regression on Facebook.
Benjamin Poulain
Comment 5
2015-03-31 12:30:09 PDT
(In reply to
comment #4
)
> Comment on
attachment 249708
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=249708&action=review
> > > Source/JavaScriptCore/features.json:42 > > + "enabled-by-default": true > > Symbol is disabled by default right now because of a regression on Facebook.
Damn, I thought that was fixed by now.
Yusuke Suzuki
Comment 6
2015-03-31 12:32:12 PDT
(In reply to
comment #5
)
> (In reply to
comment #4
) > > Comment on
attachment 249708
[details]
> > Patch > > > > View in context: > >
https://bugs.webkit.org/attachment.cgi?id=249708&action=review
> > > > > Source/JavaScriptCore/features.json:42 > > > + "enabled-by-default": true > > > > Symbol is disabled by default right now because of a regression on Facebook. > > Damn, I thought that was fixed by now.
Ah, now it's behinde runtime flags. After
https://bugs.webkit.org/show_bug.cgi?id=141106
is fixed, we can get a chance to enable it. Currently, since Object.getOwnPropertySymbols patch becomes very large, it's now splitted into several patches. The first one is
https://bugs.webkit.org/show_bug.cgi?id=143146
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug