Bug 143207 - Start the features.json files
Summary: Start the features.json files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-29 20:16 PDT by Benjamin Poulain
Modified: 2015-03-31 12:32 PDT (History)
3 users (show)

See Also:


Attachments
Patch (9.30 KB, patch)
2015-03-29 20:18 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2015-03-29 20:16:25 PDT
Start the features.json files
Comment 1 Benjamin Poulain 2015-03-29 20:18:10 PDT
Created attachment 249708 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-30 00:21:31 PDT
Comment on attachment 249708 [details]
Patch

Clearing flags on attachment: 249708

Committed r182134: <http://trac.webkit.org/changeset/182134>
Comment 3 WebKit Commit Bot 2015-03-30 00:21:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Timothy Hatcher 2015-03-31 11:55:36 PDT
Comment on attachment 249708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249708&action=review

> Source/JavaScriptCore/features.json:42
> +            "enabled-by-default": true

Symbol is disabled by default right now because of a regression on Facebook.
Comment 5 Benjamin Poulain 2015-03-31 12:30:09 PDT
(In reply to comment #4)
> Comment on attachment 249708 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249708&action=review
> 
> > Source/JavaScriptCore/features.json:42
> > +            "enabled-by-default": true
> 
> Symbol is disabled by default right now because of a regression on Facebook.

Damn, I thought that was fixed by now.
Comment 6 Yusuke Suzuki 2015-03-31 12:32:12 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > Comment on attachment 249708 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=249708&action=review
> > 
> > > Source/JavaScriptCore/features.json:42
> > > +            "enabled-by-default": true
> > 
> > Symbol is disabled by default right now because of a regression on Facebook.
> 
> Damn, I thought that was fixed by now.

Ah, now it's behinde runtime flags.
After https://bugs.webkit.org/show_bug.cgi?id=141106 is fixed, we can get a chance to enable it.
Currently, since Object.getOwnPropertySymbols patch becomes very large, it's now splitted into several patches.
The first one is https://bugs.webkit.org/show_bug.cgi?id=143146