WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
143192
[CMake] Update old CMakeList.txt in gtest
https://bugs.webkit.org/show_bug.cgi?id=143192
Summary
[CMake] Update old CMakeList.txt in gtest
Gyuyoung Kim
Reported
2015-03-29 07:46:21 PDT
It seems that CMake ports have used Source/cmake/gtest/CMakeLists.txt instead of Source/ThirdParty/gtest/CMakeLists.txt. I'm not sure if we will use Source/ThirdParty/gtest/CMakeLists.txt. If we don't have to use it in future, I think we can replace it with Source/cmake/gtest/CMakeLists.txt. However if we need to continue to keep Source/ThirdParty/gtest/CMakeLists.txt, please let me know.
Attachments
Patch
(20.02 KB, patch)
2015-03-29 08:00 PDT
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Patch
(20.03 KB, patch)
2015-03-29 08:02 PDT
,
Gyuyoung Kim
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1
2015-03-29 08:00:35 PDT
Created
attachment 249680
[details]
Patch
Gyuyoung Kim
Comment 2
2015-03-29 08:02:04 PDT
Created
attachment 249681
[details]
Patch
Gyuyoung Kim
Comment 3
2015-03-29 18:20:56 PDT
CC'ing Ossy and Alex.
WebKit Commit Bot
Comment 4
2015-03-29 19:28:10 PDT
Comment on
attachment 249681
[details]
Patch Clearing flags on attachment: 249681 Committed
r182128
: <
http://trac.webkit.org/changeset/182128
>
WebKit Commit Bot
Comment 5
2015-03-29 19:28:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug