Bug 143192 - [CMake] Update old CMakeList.txt in gtest
Summary: [CMake] Update old CMakeList.txt in gtest
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-29 07:46 PDT by Gyuyoung Kim
Modified: 2015-03-29 19:28 PDT (History)
3 users (show)

See Also:

Attachments
Patch (20.02 KB, patch)
2015-03-29 08:00 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (20.03 KB, patch)
2015-03-29 08:02 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-03-29 07:46:21 PDT 
It seems that CMake ports have used Source/cmake/gtest/CMakeLists.txt instead of Source/ThirdParty/gtest/CMakeLists.txt. I'm not sure if we will use Source/ThirdParty/gtest/CMakeLists.txt. If we don't have to use it in future, I think we can replace it with Source/cmake/gtest/CMakeLists.txt. However if we need to continue to keep Source/ThirdParty/gtest/CMakeLists.txt, please let me know.
Comment 1 Gyuyoung Kim 2015-03-29 08:00:35 PDT 
Created attachment 249680 [details]
Patch
Comment 2 Gyuyoung Kim 2015-03-29 08:02:04 PDT 
Created attachment 249681 [details]
Patch
Comment 3 Gyuyoung Kim 2015-03-29 18:20:56 PDT 
CC'ing Ossy and Alex.
Comment 4 WebKit Commit Bot 2015-03-29 19:28:10 PDT 
Comment on attachment 249681 [details]
Patch

Clearing flags on attachment: 249681

Committed r182128: <http://trac.webkit.org/changeset/182128>
Comment 5 WebKit Commit Bot 2015-03-29 19:28:14 PDT 
All reviewed patches have been landed.  Closing bug.