Bug 143189 - [Win] Allow building JavaScriptCore without Cygwin
Summary: [Win] Allow building JavaScriptCore without Cygwin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-28 22:32 PDT by Myles C. Maxfield
Modified: 2015-03-29 14:56 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.63 KB, patch)
2015-03-28 22:37 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (11.63 KB, patch)
2015-03-29 06:22 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-03-28 22:32:44 PDT 
[Win] Allow building JavaScriptCore without Cygwin
Comment 1 Myles C. Maxfield 2015-03-28 22:37:43 PDT 
Created attachment 249677 [details]
Patch
Comment 2 Myles C. Maxfield 2015-03-29 06:22:58 PDT 
Created attachment 249679 [details]
Patch
Comment 3 Brent Fulgham 2015-03-29 11:43:24 PDT 
Comment on attachment 249679 [details]
Patch

Nice work!
Comment 4 Myles C. Maxfield 2015-03-29 13:12:37 PDT 
Comment on attachment 249679 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249679&action=review

> Source/JavaScriptCore/UpdateContents.py:45
> +if (not t or comp == comparator):

This should be a !=
Comment 5 WebKit Commit Bot 2015-03-29 13:57:06 PDT 
Comment on attachment 249679 [details]
Patch

Clearing flags on attachment: 249679

Committed r182122: <http://trac.webkit.org/changeset/182122>
Comment 6 WebKit Commit Bot 2015-03-29 13:57:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Myles C. Maxfield 2015-03-29 14:56:24 PDT 
http://trac.webkit.org/changeset/182123 updates this