Bug 143184 - Add script to graph GC phase timings
Summary: Add script to graph GC phase timings
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-28 09:31 PDT by Mark Hahnenberg
Modified: 2015-04-24 23:00 PDT (History)
1 user (show)

See Also:

Attachments
Patch (17.18 KB, patch)
2015-03-28 09:41 PDT, Mark Hahnenberg 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2015-03-28 09:31:00 PDT 
This can make it easier to quickly see which particular GC phases are taking the most time and would therefore benefit the most from further scrutiny and improvement.
Comment 1 Mark Hahnenberg 2015-03-28 09:41:43 PDT 
Created attachment 249662 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-28 09:43:26 PDT 
Attachment 249662 [details] did not pass style-queue:


ERROR: Tools/Scripts/gctools/graph_phase_timings.py:66:  [graph_timings] Passing unexpected keyword argument 'startangle' in function call  [pylint/E1123] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2015-04-24 23:00:26 PDT 
Comment on attachment 249662 [details]
Patch

rs=me