Bug 143176 - Web Inspector: Adopt Array.prototype.includes and String.prototype.includes
Summary: Web Inspector: Adopt Array.prototype.includes and String.prototype.includes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-27 23:40 PDT by Joseph Pecoraro
Modified: 2015-03-28 09:38 PDT (History)
11 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (28.95 KB, patch)
2015-03-27 23:42 PDT, Joseph Pecoraro
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews105 for mac-mavericks-wk2 (563.41 KB, application/zip)
2015-03-28 00:18 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews101 for mac-mavericks (523.04 KB, application/zip)
2015-03-28 00:30 PDT, Build Bot
no flags Details
[PATCH] Proposed Fix (30.09 KB, patch)
2015-03-28 01:13 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-03-27 23:40:39 PDT
* SUMMARY
Adopt Array.prototype.includes and String.prototype.includes instead of our own implementations of Array.prototype.contains and String.prototype.contains.

- The subtle differences in implementation shouldn't affect us.
- Not to be confused with Element.prototype.contains and DOMTokenList.prototype.contains (classList).
Comment 1 Radar WebKit Bug Importer 2015-03-27 23:41:02 PDT
<rdar://problem/20336710>
Comment 2 Joseph Pecoraro 2015-03-27 23:42:31 PDT
Created attachment 249646 [details]
[PATCH] Proposed Fix
Comment 3 Build Bot 2015-03-28 00:18:42 PDT
Comment on attachment 249646 [details]
[PATCH] Proposed Fix

Attachment 249646 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4621473318699008

New failing tests:
inspector/css/pseudo-element-matches.html
Comment 4 Build Bot 2015-03-28 00:18:47 PDT
Created attachment 249650 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-03-28 00:30:29 PDT
Comment on attachment 249646 [details]
[PATCH] Proposed Fix

Attachment 249646 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6102388779778048

New failing tests:
inspector/css/pseudo-element-matches.html
Comment 6 Build Bot 2015-03-28 00:30:32 PDT
Created attachment 249651 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 7 Joseph Pecoraro 2015-03-28 01:10:44 PDT
> New failing tests:
> inspector/css/pseudo-element-matches.html

Wow, I didn't think the tests might use these functions, but they do! This was the only occurrence.
Comment 8 Joseph Pecoraro 2015-03-28 01:13:22 PDT
Created attachment 249654 [details]
[PATCH] Proposed Fix
Comment 9 WebKit Commit Bot 2015-03-28 09:38:45 PDT
Comment on attachment 249654 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 249654

Committed r182113: <http://trac.webkit.org/changeset/182113>
Comment 10 WebKit Commit Bot 2015-03-28 09:38:51 PDT
All reviewed patches have been landed.  Closing bug.