Bug 143173 – [GTK] Web Inspector: New Images for ObjectTreeView - Setter

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
New Images for ObjectTreeView - Setter. "Pencil.svg". Added in <http://trac.webkit.org/changeset/182099>

* TEST
Foo = class Foo {
    constructor() { this.value = 1; }
    get getterOnly() {}
    get getterAndSetter() {}
    set getterAndSetter(x) {}
    set setterOnly(x) {}
}
foo = new Foo;
Object.defineProperty(foo, 'value', { value: 1 });
Object.defineProperty(foo, 'getterOnly', { get: function(){ return 2; } });
Object.defineProperty(foo, 'getterAndSetter', { get: function(){ return 2; }, set(x){} });
Object.defineProperty(foo, 'setterOnly', { set(x){} });
foo;

* STEPS TO REPRODUCE
1. Evaluate the test in the console
2. Expand the object
  => "setterOnly" fields should have icons

[Radar WebKit Bug Importer]

<rdar://problem/20336142>

[Joseph Pecoraro]

See: <https://webkit.org/b/143129> Web Inspector: Add Setter Icon for ObjectTreeView

[Andres Gomez Garcia]

Getting.

Thanks for the report!

[Andres Gomez Garcia]

Created attachment 252067 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 252067 [details]
Patch

Clearing flags on attachment: 252067

Committed r183633: <http://trac.webkit.org/changeset/183633>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.