Bug 143170 - parse doesn't initialize the 16-bit version of the JSC parser with defaultConstructorKind
Summary: parse doesn't initialize the 16-bit version of the JSC parser with defaultCon...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 140491
  Show dependency tree / graph
 
Reported: 2015-03-27 18:39 PDT by Ryosuke Niwa
Modified: 2015-03-27 21:03 PDT (History)
5 users (show)

See Also:

Attachments
Cleanup (1.41 KB, patch)
2015-03-27 18:42 PDT, Ryosuke Niwa 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-03-27 18:39:08 PDT 
parse doesn't initialize the 16-bit version of the JSC parser with defaultConstructorKind
Comment 1 Ryosuke Niwa 2015-03-27 18:42:48 PDT 
Created attachment 249632 [details]
Cleanup
Comment 2 Ryosuke Niwa 2015-03-27 18:43:47 PDT 
Comment on attachment 249632 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=249632&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        since both base and derived default constructors should be using a 8-bit string.

That is, two string literals we have in BuiltinExecutables::createDefaultConstructor.
Comment 3 Benjamin Poulain 2015-03-27 20:05:32 PDT 
Comment on attachment 249632 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=249632&action=review

> Source/JavaScriptCore/parser/Parser.h:1009
> +    ASSERT(defaultConstructorKind == ConstructorKind::None);

ASSERT -> ASSERT_WITH_MESSAGE.
Comment 4 Ryosuke Niwa 2015-03-27 21:03:31 PDT 
Committed r182102: <http://trac.webkit.org/changeset/182102>