WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
143169
Web Inspector: TypeProfiler doesn't work on files with ES6 Class Syntax
https://bugs.webkit.org/show_bug.cgi?id=143169
Summary
Web Inspector: TypeProfiler doesn't work on files with ES6 Class Syntax
Joseph Pecoraro
Reported
2015-03-27 18:05:00 PDT
* SUMMARY TypeProfiler doesn't work on files with ES6 Class Syntax. * STEPS 1. Inspect test page with Classes, instantiate instances and run methods 2. Type profile said page => Models/ScriptSyntaxTree.js:789:26: CONSOLE ERROR Unsupported Syntax Tree Node: ClassExpression Probably need ClassExpression/ClassDeclaration at the least.
Attachments
[PATCH] Proposed Fix
(9.01 KB, patch)
2015-03-27 18:42 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
[PATCH] Proposed Fix
(9.48 KB, patch)
2015-03-27 19:31 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
[IMAGE] What it looks like
(83.50 KB, image/png)
2015-03-27 19:32 PDT
,
Joseph Pecoraro
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-03-27 18:05:15 PDT
<
rdar://problem/20335450
>
Joseph Pecoraro
Comment 2
2015-03-27 18:42:41 PDT
Created
attachment 249631
[details]
[PATCH] Proposed Fix
Saam Barati
Comment 3
2015-03-27 19:11:19 PDT
Comment on
attachment 249631
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=249631&action=review
Looks correct to me besides adding the one bit regarding setter/getter methods.
> Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js:715 > + };
Like what's done with "Property" below, we should do: if (result.kind === "get" || result.kind === "set") { result.value.isGetterOrSetter = true; result.value.getterOrSetterRange = result.key.range; }
Joseph Pecoraro
Comment 4
2015-03-27 19:31:43 PDT
Created
attachment 249637
[details]
[PATCH] Proposed Fix Good comment, that greatly fixed up my test case.
Joseph Pecoraro
Comment 5
2015-03-27 19:32:02 PDT
Created
attachment 249638
[details]
[IMAGE] What it looks like
WebKit Commit Bot
Comment 6
2015-03-27 22:05:08 PDT
Comment on
attachment 249637
[details]
[PATCH] Proposed Fix Clearing flags on attachment: 249637 Committed
r182106
: <
http://trac.webkit.org/changeset/182106
>
WebKit Commit Bot
Comment 7
2015-03-27 22:05:14 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug