Bug 143169 – Web Inspector: TypeProfiler doesn't work on files with ES6 Class Syntax

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
TypeProfiler doesn't work on files with ES6 Class Syntax.

* STEPS
1. Inspect test page with Classes, instantiate instances and run methods
2. Type profile said page
  => Models/ScriptSyntaxTree.js:789:26: CONSOLE ERROR Unsupported Syntax Tree Node: ClassExpression

Probably need ClassExpression/ClassDeclaration at the least.

[Radar WebKit Bug Importer]

<rdar://problem/20335450>

[Joseph Pecoraro]

Created attachment 249631 [details]
[PATCH] Proposed Fix

[Saam Barati]

Comment on attachment 249631 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=249631&action=review

Looks correct to me besides adding the one bit regarding setter/getter methods.

> Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js:715
> +            };

Like what's done with "Property" below, we should do:
if (result.kind === "get" || result.kind === "set") {
    result.value.isGetterOrSetter = true;
    result.value.getterOrSetterRange = result.key.range;
}

[Joseph Pecoraro]

Created attachment 249637 [details]
[PATCH] Proposed Fix

Good comment, that greatly fixed up my test case.

[Joseph Pecoraro]

Created attachment 249638 [details]
[IMAGE] What it looks like

[WebKit Commit Bot]

Comment on attachment 249637 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 249637

Committed r182106: <http://trac.webkit.org/changeset/182106>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.