* SUMMARY Editing Style Metrics Values no longer works. * TEST <div style="width: 100px; background: blue">Text</div> * STEPS TO REPRODUCE 1. Inspect div on test 2. Show Styles details sidebar pane 3. Show Metrics tab 4. Double click width/height 5. Input value and commit (return) => Nothing happens * NOTES - Appears to be because we removed CSSProperty.add and friends which this code was using. r179286
<rdar://problem/20334620>
Created attachment 253801 [details] [PATCH] Proposed Fix
Comment on attachment 253801 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=253801&action=review r=me > Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js:425 > + function didToggle() Reading the callback code, this will get called even if there was an error in the backend (passed: error, result, wasThrown). Should it only update if something actually changed?
(In reply to comment #3) > Comment on attachment 253801 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253801&action=review > > r=me > > > Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js:425 > > + function didToggle() > > Reading the callback code, this will get called even if there was an error > in the backend (passed: error, result, wasThrown). Should it only update if > something actually changed? I thought about doing a "style.getPropertyValue" and seeing if the value changed, but decided against it. Unknown side effects / errors could happen if someone overrides `CSSStyleDeclaration.prototype.setProperty` and ultimately still could have changed the property and so a refresh would still be useful. Always doing a refresh is the safe bet as long as we are using overridable APIs. Technically setProperty can trigger an error naturally if invoked on a readonly style, but I don't think that should ever be the case for us.
Comment on attachment 253801 [details] [PATCH] Proposed Fix Clearing flags on attachment: 253801 Committed r184925: <http://trac.webkit.org/changeset/184925>
All reviewed patches have been landed. Closing bug.