Bug 143152 - WebProcessProxy should not retain WebBackForwardListItems forever.
Summary: WebProcessProxy should not retain WebBackForwardListItems forever.
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Keywords: InRadar, Performance
Depends on:
Reported: 2015-03-27 14:15 PDT by Andreas Kling
Modified: 2015-03-27 15:02 PDT (History)
2 users (show)

See Also:

Proposed patch (3.56 KB, patch)
2015-03-27 14:19 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-03-27 14:15:24 PDT

It's silly that WebProcessProxy keeps WebBackForwardListItems around after they get evicted from the back/forward list.
We already handle the case where the web process sends an IPC message referencing an invalid back/forward list item anyway.
Comment 1 Andreas Kling 2015-03-27 14:19:33 PDT
Created attachment 249607 [details]
Proposed patch
Comment 2 Andreas Kling 2015-03-27 15:02:35 PDT
Comment on attachment 249607 [details]
Proposed patch

Clearing flags on attachment: 249607

Committed r182084: <http://trac.webkit.org/changeset/182084>
Comment 3 Andreas Kling 2015-03-27 15:02:40 PDT
All reviewed patches have been landed.  Closing bug.