Bug 143148 - Deconstruction parameters are bound too late
Summary: Deconstruction parameters are bound too late
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-27 13:32 PDT by Saam Barati
Modified: 2015-03-27 23:02 PDT (History)
6 users (show)

See Also:

Attachments
WIP (2.52 KB, patch)
2015-03-27 15:56 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
patch (4.72 KB, patch)
2015-03-27 19:15 PDT, Saam Barati 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2015-03-27 13:32:54 PDT 
consider:

```
function test({arg}) {
    print(arg);
    function arg(){}
}
test({})
```

Should print the function, not undefined.

This is a simple fix in BytecodeGenerator::generate
Comment 1 Saam Barati 2015-03-27 15:56:38 PDT 
Created attachment 249617 [details]
WIP

Waiting on a build to get tests results populated.
Comment 2 Saam Barati 2015-03-27 19:15:37 PDT 
Created attachment 249634 [details]
patch
Comment 3 Filip Pizlo 2015-03-27 22:03:13 PDT 
Comment on attachment 249634 [details]
patch

R=me.
Comment 4 Saam Barati 2015-03-27 23:02:58 PDT 
landed in:
http://trac.webkit.org/changeset/182109