Bug 143145 - [New Block-Inside-Inline Model] Create an anonymous inline block to hold blocks-inside-inlines
Summary: [New Block-Inside-Inline Model] Create an anonymous inline block to hold bloc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-27 13:01 PDT by Dave Hyatt
Modified: 2015-03-30 11:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.70 KB, patch)
2015-03-27 13:05 PDT, Dave Hyatt 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2015-03-27 13:01:22 PDT 
Create anonymous inline-blocks in order to act as containers for blocks-inside-inlines. This allows them to sit on a line and actually be properly contained within the render tree hierarchy without splitting inlines or creating continuations.
Comment 1 Dave Hyatt 2015-03-27 13:05:23 PDT 
Created attachment 249600 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-27 13:07:56 PDT 
Attachment 249600 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderInline.cpp:370:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
ERROR: Source/WebCore/rendering/RenderInline.cpp:382:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/rendering/RenderInline.cpp:384:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 3 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2015-03-30 11:03:39 PDT 
Fixed in r182146.