Bug 143144 - Null dereference in InbandMetadataTextTrack handling
Summary: Null dereference in InbandMetadataTextTrack handling
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
Depends on:
Reported: 2015-03-27 12:45 PDT by Brent Fulgham
Modified: 2015-03-27 13:42 PDT (History)
5 users (show)

See Also:

Patch (2.56 KB, patch)
2015-03-27 12:49 PDT, Brent Fulgham
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-03-27 12:45:02 PDT
We've seen some crashes due to a null dereference in InbandMetadataTextTrackAVF::updatePendingCueEndTimes. Reviewing the code, I notice that the client() return value is used without null check, even though the other methods in this class due check for null.

This patch adds a null check for client()'s return value to avoid this crash.
Comment 1 Brent Fulgham 2015-03-27 12:45:25 PDT
Comment 2 Brent Fulgham 2015-03-27 12:49:55 PDT
Created attachment 249598 [details]
Comment 3 Brent Fulgham 2015-03-27 13:42:15 PDT
Committed r182076: <http://trac.webkit.org/changeset/182076>