Bug 143140 – IteratorClose should be called when jumping over the target for-of loop

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Yusuke Suzuki]

When executing the following script,

var iter = ...;

outer: for (var i of array) {
    for (var j of iter) {
        break outer;
    }
}

iter.return should be called.

[Yusuke Suzuki]

The patch is already submitted in https://bugs.webkit.org/show_bug.cgi?id=142575,
I'll move it to here.

[Yusuke Suzuki]

Created attachment 249659 [details]
Patch

[Yusuke Suzuki]

Created attachment 249660 [details]
Patch

[Yusuke Suzuki]

Created attachment 249661 [details]
Patch

[Yusuke Suzuki]

Created attachment 249743 [details]
Patch

[Geoffrey Garen]

Comment on attachment 249743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249743&action=review

r=me

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2358
> +            } else if (finallyContext.iterator) {

This should be an else with an ASSERT. It shouldn't be possible to have a finally context without either a block of code or an iterator close.

[Yusuke Suzuki]

Comment on attachment 249743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249743&action=review

Thank you for your review! I'll fix and land it.

>> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:2358
>> +            } else if (finallyContext.iterator) {
> 
> This should be an else with an ASSERT. It shouldn't be possible to have a finally context without either a block of code or an iterator close.

You're right. Use else and ASSERT instead.

[Yusuke Suzuki]

Committed r182226: <http://trac.webkit.org/changeset/182226>