Bug 143139 – Web Inspector: Uncaught Exception: TypeError: Attempted to assign to readonly - DOMNodeDetailsSidebarPanel.js

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Uncaught Exception: TypeError: Attempted to assign to readonly.

[Error] Uncaught exception in inspector page while handling event DOM.attributeModified:  TypeError: Attempted to assign to readonly property.
    _createAttributesDataGrid @ /Views/DOMNodeDetailsSidebarPanel.js:587:17
    _refreshAttributes @ /Views/DOMNodeDetailsSidebarPanel.js:122:78
    _attributesChanged @ /Views/DOMNodeDetailsSidebarPanel.js:537:32
    dispatch @ /Base/Object.js:129:55
    dispatchEventToListeners @ /Base/Object.js:136:17
    _attributeModified @ /Controllers/DOMTreeManager.js:136:38
    attributeModified @ /Protocol/DOMObserver.js:42:55
    dispatchEvent @ /Protocol/InspectorBackend.js:353:42
    _dispatchEvent @ /Protocol/InspectorBackend.js:233:32
    dispatch @ /Protocol/InspectorBackend.js:88:32
    dispatchNextQueuedMessageFromBackend @ /Protocol/MessageDispatcher.js:42:34

Not exactly sure how to reproduce, but I was playing with DOM nodes in the console and may have modified an attribute myself.

[Radar WebKit Bug Importer]

<rdar://problem/20329695>

[Joseph Pecoraro]

Looks like there are plenty of places that set the selectable state of a DataGridNode:

    var node = new WebInspector.DataGridNode({name: attribute.name, value: attribute.value || ""}, false);
    node.selectable = true;

But DataGridNode only has a getter for "selectable" not a setter.

[Joseph Pecoraro]

* STEPS TO REPRODUCE
1. Inspect any page with an image
2. Show the Node details sidebar for an image
3. Expand Attributes Section
  => exceptions in inspector

[Joseph Pecoraro]

Created attachment 249593 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 249593 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 249593

Committed r182092: <http://trac.webkit.org/changeset/182092>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.