Bug 143138 - [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
Summary: [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-27 11:01 PDT by Gyuyoung Kim
Modified: 2015-03-27 21:19 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.13 KB, patch)
2015-03-27 11:03 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (4.48 KB, patch)
2015-03-27 19:39 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-03-27 11:01:41 PDT 
INCLUDE_IF_EXISTS isn't used except for 2 places. However the uses can be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
Comment 1 Gyuyoung Kim 2015-03-27 11:03:31 PDT 
Created attachment 249586 [details]
Patch
Comment 2 Csaba Osztrogonác 2015-03-27 11:23:43 PDT 
Comment on attachment 249586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review

LGTM, r=me with a minor change.

> Tools/DumpRenderTree/CMakeLists.txt:-72
> -WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
> -

I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once.
Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" )
Comment 3 Alex Christensen 2015-03-27 11:31:26 PDT 
Comment on attachment 249586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review

>> Tools/DumpRenderTree/CMakeLists.txt:-72
>> -
> 
> I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once.
> Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" )

None of the CMake ports use DumpRenderTree anymore, right?  We could remove this file completely, but I'd just have to add it again once somebody (probably me) gets Mac and Windows working with CMake.  Let's just leave it alone right now and I'll get to it.
Comment 4 Gyuyoung Kim 2015-03-27 19:39:28 PDT 
Created attachment 249640 [details]
Patch for landing
Comment 5 Gyuyoung Kim 2015-03-27 19:40:54 PDT 
Comment on attachment 249586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review

>>> Tools/DumpRenderTree/CMakeLists.txt:-72
>>> -
>> 
>> I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once.
>> Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" )
> 
> None of the CMake ports use DumpRenderTree anymore, right?  We could remove this file completely, but I'd just have to add it again once somebody (probably me) gets Mac and Windows working with CMake.  Let's just leave it alone right now and I'll get to it.

I see. Let's leave it as is for upcoming PlatformFoo.cmake use.
Comment 6 WebKit Commit Bot 2015-03-27 21:18:58 PDT 
Comment on attachment 249640 [details]
Patch for landing

Clearing flags on attachment: 249640

Committed r182103: <http://trac.webkit.org/changeset/182103>
Comment 7 WebKit Commit Bot 2015-03-27 21:19:04 PDT 
All reviewed patches have been landed.  Closing bug.