Bug 143138 – [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Gyuyoung Kim]

INCLUDE_IF_EXISTS isn't used except for 2 places. However the uses can be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.

[Gyuyoung Kim]

Created attachment 249586 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 249586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review

LGTM, r=me with a minor change.

> Tools/DumpRenderTree/CMakeLists.txt:-72
> -WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
> -

I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once.
Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" )

[Alex Christensen]

Comment on attachment 249586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review

>> Tools/DumpRenderTree/CMakeLists.txt:-72
>> -
> 
> I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once.
> Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" )

None of the CMake ports use DumpRenderTree anymore, right?  We could remove this file completely, but I'd just have to add it again once somebody (probably me) gets Mac and Windows working with CMake.  Let's just leave it alone right now and I'll get to it.

[Gyuyoung Kim]

Created attachment 249640 [details]
Patch for landing

[Gyuyoung Kim]

Comment on attachment 249586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249586&action=review

>>> Tools/DumpRenderTree/CMakeLists.txt:-72
>>> -
>> 
>> I think we can leave it as is, maybe Win or Mac will need PlatformXXX.cmake once.
>> Removing this could make strange error in the future. ( "why PlatformXXX.cmake doesn't work?" )
> 
> None of the CMake ports use DumpRenderTree anymore, right?  We could remove this file completely, but I'd just have to add it again once somebody (probably me) gets Mac and Windows working with CMake.  Let's just leave it alone right now and I'll get to it.

I see. Let's leave it as is for upcoming PlatformFoo.cmake use.

[WebKit Commit Bot]

Comment on attachment 249640 [details]
Patch for landing

Clearing flags on attachment: 249640

Committed r182103: <http://trac.webkit.org/changeset/182103>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.