It may be cleaner to wrap all JS source specific handling (errors in particular) in separate classes from the core ReadableStream/ReadableStreamReader classes.
Created attachment 249568 [details] Patch
Created attachment 249817 [details] Patch
Created attachment 249971 [details] Fixed memory leak
Comment on attachment 249971 [details] Fixed memory leak View in context: https://bugs.webkit.org/attachment.cgi?id=249971&action=review I am quite surprised you specialize the reader, I was expecting a subclass only for ReadableStream. I guess ReadableJSStream and ReadableJSStreamReader will grow right? I would give them their own header. r=me in any case, no problem with this patch. > Source/WebCore/ChangeLog:16 > + (WebCore::ReadableStream::ReadableStream): Moved suspendIfNeeded inside constructor to ese subclassing. Typo: ese > Source/WebCore/bindings/js/ReadableStreamJSSource.h:65 > + Useless blank line here.
Thanks for the review. (In reply to comment #4) > Comment on attachment 249971 [details] > Fixed memory leak > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249971&action=review > > I am quite surprised you specialize the reader, I was expecting a subclass > only for ReadableStream. ReadableJSStreamReader sole purpose is to store JS errors as a JSC::Strong. ReadableStream does also the chunk queue management. > I guess ReadableJSStream and ReadableJSStreamReader will grow right? I would > give them their own header. Yes, maybe we could move ReadableJSStream and ReadableJSStreamReader to a different file. I would keep both classes together, ReadableJSStreamReader taking only 15 lines with the error storage code. > > r=me in any case, no problem with this patch. Great! > > Source/WebCore/ChangeLog:16 > > + (WebCore::ReadableStream::ReadableStream): Moved suspendIfNeeded inside constructor to ese subclassing. > > Typo: ese OK > > > Source/WebCore/bindings/js/ReadableStreamJSSource.h:65 > > + > > Useless blank line here. OK
Created attachment 250049 [details] Patch for landing
Created attachment 250050 [details] Patch for landing
Comment on attachment 250050 [details] Patch for landing Clearing flags on attachment: 250050 Committed r182309: <http://trac.webkit.org/changeset/182309>
All reviewed patches have been landed. Closing bug.