Bug 143120 - Optimized Fullscreen fails to cleanup becuase of no longer necessary release of m_playerController in exitFullscreen()
Summary: Optimized Fullscreen fails to cleanup becuase of no longer necessary release ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-26 16:31 PDT by Jeremy Jones
Modified: 2015-03-27 10:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.93 KB, patch)
2015-03-26 16:36 PDT, Jeremy Jones 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing. (1.93 KB, patch)
2015-03-26 22:44 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2015-03-26 16:31:33 PDT 
Optimized Fullscreen fails to cleanup becuase of no longer necessary release of m_playerController in exitFullscreen()
Comment 1 Jeremy Jones 2015-03-26 16:36:01 PDT 
Created attachment 249540 [details]
Patch
Comment 2 Jeremy Jones 2015-03-26 16:37:07 PDT 
rdar://problem/19445613
Comment 3 Eric Carlson 2015-03-26 17:29:12 PDT 
Comment on attachment 249540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249540&action=review

> Source/WebCore/ChangeLog:11
> +        WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releaseing it prematurely can actually prevent the exit

Nit: "Releaseing"-" "Releasing"
Comment 4 Jon Lee 2015-03-26 18:38:11 PDT 
rdar://problem/20263463
Comment 5 Jeremy Jones 2015-03-26 22:43:54 PDT 
(In reply to comment #3)
> Comment on attachment 249540 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249540&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releaseing it prematurely can actually prevent the exit
> 
> Nit: "Releaseing"-" "Releasing"

Fixes that and three other typos!
Comment 6 Jeremy Jones 2015-03-26 22:44:00 PDT 
Created attachment 249552 [details]
Patch for landing.
Comment 7 WebKit Commit Bot 2015-03-26 23:37:32 PDT 
Comment on attachment 249552 [details]
Patch for landing.

Clearing flags on attachment: 249552

Committed r182052: <http://trac.webkit.org/changeset/182052>