Bug 143120 – Optimized Fullscreen fails to cleanup becuase of no longer necessary release of m_playerController in exitFullscreen()

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeremy Jones]

Optimized Fullscreen fails to cleanup becuase of no longer necessary release of m_playerController in exitFullscreen()

[Jeremy Jones]

Created attachment 249540 [details]
Patch

[Jeremy Jones]

rdar://problem/19445613

[Eric Carlson]

Comment on attachment 249540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249540&action=review

> Source/WebCore/ChangeLog:11
> +        WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releaseing it prematurely can actually prevent the exit

Nit: "Releaseing"-" "Releasing"

[Jon Lee]

rdar://problem/20263463

[Jeremy Jones]

(In reply to comment #3)
> Comment on attachment 249540 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249540&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(). Releaseing it prematurely can actually prevent the exit
> 
> Nit: "Releaseing"-" "Releasing"

Fixes that and three other typos!

[Jeremy Jones]

Created attachment 249552 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 249552 [details]
Patch for landing.

Clearing flags on attachment: 249552

Committed r182052: <http://trac.webkit.org/changeset/182052>