Bug 143116 - Apply blur effect to media control background
Summary: Apply blur effect to media control background
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-26 15:20 PDT by Roger Fong
Modified: 2015-03-26 16:25 PDT (History)
5 users (show)

See Also:


Attachments
patch (16.94 KB, patch)
2015-03-26 15:30 PDT, Roger Fong
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (602.84 KB, application/zip)
2015-03-26 15:50 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (652.47 KB, application/zip)
2015-03-26 15:55 PDT, Build Bot
no flags Details
patch (19.50 KB, patch)
2015-03-26 16:05 PDT, Roger Fong
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2015-03-26 15:20:52 PDT
See summary.
Comment 1 Roger Fong 2015-03-26 15:21:58 PDT
rdar://problem/20316964
Comment 2 Roger Fong 2015-03-26 15:30:26 PDT
Created attachment 249519 [details]
patch
Comment 3 Build Bot 2015-03-26 15:50:44 PDT
Comment on attachment 249519 [details]
patch

Attachment 249519 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5696776363311104

New failing tests:
media/video-volume-slider-drag.html
http/tests/media/hls/video-controls-live-stream.html
fullscreen/video-controls-override.html
Comment 4 Build Bot 2015-03-26 15:50:46 PDT
Created attachment 249523 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 5 Build Bot 2015-03-26 15:55:45 PDT
Comment on attachment 249519 [details]
patch

Attachment 249519 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5629456240607232

New failing tests:
media/video-volume-slider-drag.html
http/tests/media/hls/video-controls-live-stream.html
fullscreen/video-controls-override.html
Comment 6 Build Bot 2015-03-26 15:55:48 PDT
Created attachment 249526 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 7 Roger Fong 2015-03-26 16:05:42 PDT
Created attachment 249532 [details]
patch
Comment 8 Brent Fulgham 2015-03-26 16:15:18 PDT
Comment on attachment 249532 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249532&action=review

r=me

> Source/WebCore/ChangeLog:10
> +        and the volume slider background not showing the blur effect. Iâll fix those separately.

Bad character in ChangeLog. --> I'll

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1132
> +        ctx.fillStyle = "rgba(140, 140, 140, .68)";

I think we usually write this as "0.68", not ".68"

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1193
> +        ctx.fillStyle = "rgba(140, 140, 140, .68)";

Ditto the leading zero. (.68 -> 0.68)
Comment 9 Roger Fong 2015-03-26 16:25:00 PDT
http://trac.webkit.org/changeset/182036