WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
143112
progress towards cmake on mac
https://bugs.webkit.org/show_bug.cgi?id=143112
Summary
progress towards cmake on mac
Alex Christensen
Reported
2015-03-26 13:16:11 PDT
More things missing from mac cmake files. There are still problems, but these are the things I'm pretty sure about.
Attachments
Patch
(19.19 KB, patch)
2015-03-26 13:22 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(19.43 KB, patch)
2015-03-26 13:46 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2015-03-26 13:22:33 PDT
Created
attachment 249511
[details]
Patch
Alex Christensen
Comment 2
2015-03-26 13:46:06 PDT
Created
attachment 249512
[details]
Patch
Chris Dumez
Comment 3
2015-03-26 14:38:37 PDT
Comment on
attachment 249512
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=249512&action=review
r=me with comments.
> Source/WebCore/PlatformMac.cmake:46 > + crypto/CommonCryptoUtilities.cpp
PlatformEfl.cmake and PlatforkGtk.cmake already have these in a ENABLE_SUBTLE_CRYPTO section. We should probably move these into a cross platform CMake config file, and protect with ENABLE_SUBTLE_CRYPTO.
> Source/WebCore/PlatformMac.cmake:181 > + platform/graphics/opengl/Extensions3DOpenGL.cpp
It looks like a few of those could be in a cross-platform if (WTF_USE_OPENGL) section (at least Extensions3DOpenGL.cpp, GraphicsContext3DOpenGL.cpp). GTK and EFL already have such sections.
> Source/WebCore/PlatformMac.cmake:316 > +
Why the new line?
Alex Christensen
Comment 4
2015-03-26 15:10:56 PDT
(In reply to
comment #3
)
> Why the new line?
Stylebot.
WebKit Commit Bot
Comment 5
2015-03-26 15:54:30 PDT
Comment on
attachment 249512
[details]
Patch Clearing flags on attachment: 249512 Committed
r182032
: <
http://trac.webkit.org/changeset/182032
>
WebKit Commit Bot
Comment 6
2015-03-26 15:54:35 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug