More things missing from mac cmake files. There are still problems, but these are the things I'm pretty sure about.
Created attachment 249511 [details] Patch
Created attachment 249512 [details] Patch
Comment on attachment 249512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249512&action=review r=me with comments. > Source/WebCore/PlatformMac.cmake:46 > + crypto/CommonCryptoUtilities.cpp PlatformEfl.cmake and PlatforkGtk.cmake already have these in a ENABLE_SUBTLE_CRYPTO section. We should probably move these into a cross platform CMake config file, and protect with ENABLE_SUBTLE_CRYPTO. > Source/WebCore/PlatformMac.cmake:181 > + platform/graphics/opengl/Extensions3DOpenGL.cpp It looks like a few of those could be in a cross-platform if (WTF_USE_OPENGL) section (at least Extensions3DOpenGL.cpp, GraphicsContext3DOpenGL.cpp). GTK and EFL already have such sections. > Source/WebCore/PlatformMac.cmake:316 > + Why the new line?
(In reply to comment #3) > Why the new line? Stylebot.
Comment on attachment 249512 [details] Patch Clearing flags on attachment: 249512 Committed r182032: <http://trac.webkit.org/changeset/182032>
All reviewed patches have been landed. Closing bug.