Bug 143112 - progress towards cmake on mac
Summary: progress towards cmake on mac
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Depends on: 144736
  Show dependency treegraph
Reported: 2015-03-26 13:16 PDT by Alex Christensen
Modified: 2015-05-07 08:32 PDT (History)
4 users (show)

See Also:

Patch (19.19 KB, patch)
2015-03-26 13:22 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (19.43 KB, patch)
2015-03-26 13:46 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-03-26 13:16:11 PDT
More things missing from mac cmake files.  There are still problems, but these are the things I'm pretty sure about.
Comment 1 Alex Christensen 2015-03-26 13:22:33 PDT
Created attachment 249511 [details]
Comment 2 Alex Christensen 2015-03-26 13:46:06 PDT
Created attachment 249512 [details]
Comment 3 Chris Dumez 2015-03-26 14:38:37 PDT
Comment on attachment 249512 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=249512&action=review

r=me with comments.

> Source/WebCore/PlatformMac.cmake:46
> +    crypto/CommonCryptoUtilities.cpp

PlatformEfl.cmake and PlatforkGtk.cmake already have these in a ENABLE_SUBTLE_CRYPTO section. We should probably move these into a cross platform CMake config file, and protect with ENABLE_SUBTLE_CRYPTO.

> Source/WebCore/PlatformMac.cmake:181
> +    platform/graphics/opengl/Extensions3DOpenGL.cpp

It looks like a few of those could be in a cross-platform if (WTF_USE_OPENGL) section (at least Extensions3DOpenGL.cpp, GraphicsContext3DOpenGL.cpp). GTK and EFL already have such sections.

> Source/WebCore/PlatformMac.cmake:316
> +

Why the new line?
Comment 4 Alex Christensen 2015-03-26 15:10:56 PDT
(In reply to comment #3)
> Why the new line?
Comment 5 WebKit Commit Bot 2015-03-26 15:54:30 PDT
Comment on attachment 249512 [details]

Clearing flags on attachment: 249512

Committed r182032: <http://trac.webkit.org/changeset/182032>
Comment 6 WebKit Commit Bot 2015-03-26 15:54:35 PDT
All reviewed patches have been landed.  Closing bug.