Bug 143108 – Web Inspector: Convert sidebar classes to ES6

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Timothy Hatcher]

The sidebar classes are easy to convert and working fine.

[Radar WebKit Bug Importer]

<rdar://problem/20312676>

[Timothy Hatcher]

Created attachment 249503 [details]
Patch

[Timothy Hatcher]

Created attachment 249504 [details]
Patch (Ignore Space)

[Joseph Pecoraro]

Comment on attachment 249504 [details]
Patch (Ignore Space)

View in context: https://bugs.webkit.org/attachment.cgi?id=249504&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:140
> +WebInspector.ApplicationCacheDetailsSidebarPanel.StyleClassName = "application-cache";

For single use StyleClassName's I've inlining them. Donno if you feel the same, but this feels really verbose for little benefit.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:36
> -    this.element.classList.add(WebInspector.DOMNodeDetailsSidebarPanel.StyleClassName);
> +        this.element.classList.add("dom-node");

I see sometimes you have been doing this as well.

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:589
> +            console.log(attribute.name, attribute.value);
> +
>              var node = new WebInspector.DataGridNode({name: attribute.name, value: attribute.value || ""}, false);
> +            console.log(node);

Looks like debug logging we should remove.

> Source/WebInspectorUI/UserInterface/Views/Sidebar.js:274
> +    CollapsedStateDidChange: "sidebar-sidebar-collapsed-state-did-change",

Compared to the others, this one has an extra "sidebar-".

[Timothy Hatcher]

Comment on attachment 249503 [details]
Patch

https://trac.webkit.org/r182041