Web Inspector: Convert some View classes to ES6 classes

[Timothy Hatcher]

Some of the simple View classes can be converted now. The rest are harder.

[Radar WebKit Bug Importer]

<rdar://problem/20311871>

[Timothy Hatcher]

Created attachment 249497 [details]
Patch

[Timothy Hatcher]

Created attachment 249498 [details]
Patch

[Timothy Hatcher]

Created attachment 249501 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 249501 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249501&action=review

r=me

> Source/WebInspectorUI/ChangeLog:41
> +        Converted to ES6 ckasses.

Typo: "ckasses" => "classes"

> Source/WebInspectorUI/UserInterface/Views/ContextMenu.js:150
> +    constructor(event) {

Nit: Style, brace should be on newline.

> Source/WebInspectorUI/UserInterface/Views/EditingSupport.js:81
> +        this.commitHandler = commitHandler;

Could make these _foo.

> Source/WebInspectorUI/UserInterface/Views/GoToLineDialog.js:122
> +            event.preventDefault();

Is this fixing a bug?

> Source/WebInspectorUI/UserInterface/Views/SearchBar.js:47
> +        this._searchInput.addEventListener("search", this._handleSearchEvent.bind(this), false);
> +        this._searchInput.addEventListener("keydown", this._handleKeydownEvent.bind(this), false);

Style: I think we have been dropping the false for useCapture for addEventListener. We can update that here.

[Timothy Hatcher]

Comment on attachment 249501 [details]
Patch

https://trac.webkit.org/r182040