Bug 143106 - Web Inspector: Convert Base and Protocol files to ES6 classes
Summary: Web Inspector: Convert Base and Protocol files to ES6 classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks: 142891
  Show dependency tree / graph
 
Reported: 2015-03-26 10:53 PDT by Timothy Hatcher
Modified: 2015-04-21 20:31 PDT (History)
8 users (show)

See Also:

Attachments
Patch (78.03 KB, patch)
2015-03-26 10:56 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (82.33 KB, patch)
2015-03-26 11:14 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (81.20 KB, patch)
2015-03-26 11:17 PDT, Timothy Hatcher 		joepeck: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2015-03-26 10:53:10 PDT 
Do it! It is much simpler than Views.
Comment 1 Radar WebKit Bug Importer 2015-03-26 10:53:38 PDT 
<rdar://problem/20311614>
Comment 2 Timothy Hatcher 2015-03-26 10:56:17 PDT 
Created attachment 249496 [details]
Patch
Comment 3 Timothy Hatcher 2015-03-26 11:14:40 PDT 
Created attachment 249499 [details]
Patch
Comment 4 Timothy Hatcher 2015-03-26 11:17:47 PDT 
Created attachment 249500 [details]
Patch
Comment 5 WebKit Commit Bot 2015-03-26 11:20:42 PDT 
Attachment 249500 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:362:  Line contains single-quote character.  [js/syntax] [5]
ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:376:  Line contains single-quote character.  [js/syntax] [5]
ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:422:  Line contains single-quote character.  [js/syntax] [5]
ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:430:  Line contains single-quote character.  [js/syntax] [5]
ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:450:  Line contains single-quote character.  [js/syntax] [5]
ERROR: Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:462:  Line contains single-quote character.  [js/syntax] [5]
Total errors found: 6 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Joseph Pecoraro 2015-03-26 11:25:42 PDT 
Comment on attachment 249499 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249499&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/EventListenerSet.js:36
> +        this.name = name;

Should we fix this to be "_name"?

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:362
> +    'use strict';

Style: Double quotes.

> Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:508
> +        this.eventName = eventName;
> +        this.parameterNames = parameterNames;

Nit: _foo?

> Source/WebInspectorUI/UserInterface/Protocol/MessageDispatcher.js:27
> -WebInspector.messagesToDispatch = [];
> +WebInspector._messagesToDispatch = [];

Doh, I rather liked this one without the underscore.
Comment 7 Joseph Pecoraro 2015-03-26 11:26:17 PDT 
Comment on attachment 249500 [details]
Patch

Same comments probably apply.
Comment 8 Timothy Hatcher 2015-03-26 16:39:09 PDT 
Comment on attachment 249500 [details]
Patch

https://trac.webkit.org/r182039