Bug 143091 – Botwatcher's dashboard doesn't show JSC test regressions on Apple bots

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

Botwatcher's dashboard collect results from WK1 and WK2 tester bots 
only, but Apple's WK1 and WK2 tester bots don't run JSC tests anymore.

history:
- https://trac.webkit.org/changeset/180945 added dedicated JSC tester 
bots for Yosemite and disabled JSC tests on Mavericks WK2 bots.
- https://trac.webkit.org/changeset/181962 disabled JSC tests on the 
Mavericks WK1 bots, because it isn't so important for Apple anymore.
- 32-bit JSC and LLINT CLoop bots weren't checked by dashboard ever

Now only JSC regressions happen on GTK and EFL bots are shown
on the Botwatcher's dashboard. It would be great to show Apple
Yosemite, 32 bit and cloop results on it.

[Alexey Proskuryakov]

> Now only JSC regressions happen on GTK and EFL bots are shown
on the Botwatcher's dashboard.

Windows also runs JSC tests in the same queue as layout tests.

I agree that we should have JSC test results on the dashboard. I'd ask to add them in such a way that we don't get many new green bubbles when everything is good though, we are at a point where we need to collapse bubbles so that they could fit on one screen for most people.

These are the JSC queues that we have on Mac:

Apple Mavericks 32-bit JSC (BuildAndTest)
Apple Yosemite 32-bit JSC (BuildAndTest)
Apple Yosemite Debug JSC (Tests)
Apple Yosemite Release JSC (Tests)
Apple Mavericks LLINT CLoop (BuildAndTest)
Apple Yosemite LLINT CLoop (BuildAndTest)

[Alexey Proskuryakov]

rdar://problem/19330328

[Alexey Proskuryakov]

Created attachment 253741 [details]
proposed patch

[Timothy Hatcher]

Comment on attachment 253741 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253741&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:46
> +        if ("combinedQueues" in queuesInfo[id]) {

Usually best to just test the value for non-null (buildbot.queuesInfo[id].combinedQueues) It could exist but still be null/undefined.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:123
> +            if ("combinedQueues" in queueInfo) {

Ditto.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:34
> +        if ("combinedQueues" in buildbot.queuesInfo[id]) {

Ditto.

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/r184879>.