Bug 143078 - OSR availability analysis would be more scalable (and correct) if it did more liveness pruning
Summary: OSR availability analysis would be more scalable (and correct) if it did more...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
: 144883 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-03-25 21:10 PDT by Filip Pizlo
Modified: 2015-05-12 11:03 PDT (History)
13 users (show)

See Also:

Attachments
the patch (7.17 KB, patch)
2015-05-11 22:20 PDT, Filip Pizlo 		kling: review+
Details | Formatted Diff | Diff
Test failing w/o eager compilation (306 bytes, application/x-javascript)
2015-05-12 09:55 PDT, Basile Clement 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-03-25 21:10:58 PDT 
...
Comment 1 Filip Pizlo 2015-05-11 21:58:40 PDT 
*** Bug 144883 has been marked as a duplicate of this bug. ***
Comment 2 Filip Pizlo 2015-05-11 22:20:05 PDT 
Created attachment 252936 [details]
the patch
Comment 3 WebKit Commit Bot 2015-05-11 22:21:37 PDT 
Attachment 252936 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGAvailabilityMap.cpp:71:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Basile Clement 2015-05-12 09:55:03 PDT 
Created attachment 252968 [details]
Test failing w/o eager compilation

This is a modified version of the test case in fpizlo's patch that fails even without eager compilation enabled.
Comment 5 Filip Pizlo 2015-05-12 10:56:50 PDT 
(In reply to comment #4)
> Created attachment 252968 [details]
> Test failing w/o eager compilation
> 
> This is a modified version of the test case in fpizlo's patch that fails
> even without eager compilation enabled.

Thanks!  I added this test.
Comment 6 Filip Pizlo 2015-05-12 11:03:26 PDT 
Landed in http://trac.webkit.org/changeset/184206