Bug 143069 - Update prepare-ChangeLog to work with ES6 Class syntax
Summary: Update prepare-ChangeLog to work with ES6 Class syntax
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-25 20:06 PDT by Joseph Pecoraro
Modified: 2015-03-25 21:38 PDT (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (10.32 KB, patch)
2015-03-25 20:07 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (13.65 KB, patch)
2015-03-25 20:21 PDT, Joseph Pecoraro
joepeck: commit-queue-
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (13.60 KB, patch)
2015-03-25 20:37 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-03-25 20:06:29 PDT
* SUMMARY
Update prepare-ChangeLog to work with ES6 Class syntax. Currently it doesn't understand method syntax, so any modifications to Web Inspector files with class syntax produces nothing.
Comment 1 Joseph Pecoraro 2015-03-25 20:07:15 PDT
Created attachment 249465 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2015-03-25 20:08:37 PDT
Comment on attachment 249465 [details]
[PATCH] Proposed Fix

I just realized there are tests. Let me add some quick tests.
Comment 3 Joseph Pecoraro 2015-03-25 20:21:17 PDT
Created attachment 249468 [details]
[PATCH] Proposed Fix
Comment 4 Joseph Pecoraro 2015-03-25 20:26:57 PDT
Comment on attachment 249468 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=249468&action=review

> Tools/Scripts/prepare-ChangeLog:1393
> +                    $currentMethod =~ s/\.{2,}/\./g; # Removes consecutive periods.

I have a feeling this line is not needed, insect later when this is pop'd it'll do this. So cq- and I can fix locally if that is the case.
Comment 5 Joseph Pecoraro 2015-03-25 20:37:04 PDT
Created attachment 249469 [details]
[PATCH] Proposed Fix

Nope, that caused issue. But I still tweaked things just a bit to remove duplicated work.
Comment 6 WebKit Commit Bot 2015-03-25 21:38:19 PDT
Comment on attachment 249469 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 249469

Committed r181996: <http://trac.webkit.org/changeset/181996>
Comment 7 WebKit Commit Bot 2015-03-25 21:38:23 PDT
All reviewed patches have been landed.  Closing bug.