Bug 143068 - [Cocoa] RemoteInspectorXPCConnection::deserializeMessage() leaks a NSDictionary under Objective-C GC
Summary: [Cocoa] RemoteInspectorXPCConnection::deserializeMessage() leaks a NSDictiona...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-25 18:58 PDT by Andy Estes
Modified: 2015-03-25 20:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2015-03-25 19:00 PDT, Andy Estes 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2015-03-25 18:58:37 PDT 
[Cocoa] RemoteInspectorXPCConnection::deserializeMessage() leaks a NSDictionary under Objective-C GC
Comment 1 Andy Estes 2015-03-25 19:00:55 PDT 
Created attachment 249462 [details]
Patch
Comment 2 mitz 2015-03-25 19:34:21 PDT 
Comment on attachment 249462 [details]
Patch

Could you have fixed this by adopting the result of _CFXPCCreate… into a RetainPtr and not having to think about GC here?
Comment 3 Andy Estes 2015-03-25 19:52:05 PDT 
(In reply to comment #2)
> Comment on attachment 249462 [details]
> Patch
> 
> Could you have fixed this by adopting the result of _CFXPCCreate… into a
> RetainPtr and not having to think about GC here?

Oh, yes! I guess I didn't know / forgot that RetainPtr had an autorelease(). I'll assume that your r+ is still good for doing that instead :) Thanks!
Comment 4 Andy Estes 2015-03-25 20:11:46 PDT 
Committed r181992: <http://trac.webkit.org/changeset/181992>