Bug 143062 - Web Inspector: Add ESLint "Disallow Undeclared Variables" rule and enable ES6 env
Summary: Web Inspector: Add ESLint "Disallow Undeclared Variables" rule and enable ES6...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-03-25 15:30 PDT by Tobias Reiss
Modified: 2015-03-25 17:47 PDT (History)
8 users (show)

See Also:

Attachments
patch (1.44 KB, patch)
2015-03-25 15:37 PDT, Tobias Reiss 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Reiss 2015-03-25 15:30:10 PDT 
As a consequence of further usage of ES6 syntax and a regression that could have been spotted by ESLint we should add the following 2 things:
- es6 environment (allow use of ES6 syntax including class)
- no-undef - disallow use of undeclared variables unless mentioned in a /*global */ block  http://eslint.org/docs/rules/no-undef.html
Comment 1 Radar WebKit Bug Importer 2015-03-25 15:30:32 PDT 
<rdar://problem/20300065>
Comment 2 Tobias Reiss 2015-03-25 15:37:03 PDT 
Created attachment 249433 [details]
patch
Comment 3 Joseph Pecoraro 2015-03-25 17:00:02 PDT 
Comment on attachment 249433 [details]
patch

r=me
Comment 4 WebKit Commit Bot 2015-03-25 17:47:41 PDT 
Comment on attachment 249433 [details]
patch

Clearing flags on attachment: 249433

Committed r181987: <http://trac.webkit.org/changeset/181987>
Comment 5 WebKit Commit Bot 2015-03-25 17:47:45 PDT 
All reviewed patches have been landed.  Closing bug.