TEST: ./Tools/gtk/../../WebKitBuild/Release/bin/TestWebKitAPI/WebKit2Gtk/TestInspectorServer... (pid=5804) /webkit2/WebKitWebInspectorServer/test-page-list: OK /webkit2/WebKitWebInspectorServer/test-remote-debugging-message: OK /webkit2/WebKitWebInspectorServer/test-open-debugging-session: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:241:void openRemoteDebuggingSession(InspectorServerTest*, gconstpointer): assertion failed: (javascriptResult) FAIL I haven't had time to investigate the issue.
So we fixed an early runtime error in the frontend soon after that: http://trac.webkit.org/changeset/181905 Can you see if this test still fails after that revision?
(In reply to comment #1) > So we fixed an early runtime error in the frontend soon after that: > http://trac.webkit.org/changeset/181905 > > Can you see if this test still fails after that revision? Yes, remote inspector is still broken. I see a lot of js errors in the console, like: TypeError: undefined is not an object (evaluating 'this.modifierKeys.altKey') TypeError: undefined is not an object (evaluating 'WebInspector.Resizer.RuleOrientation.Vertical') It seems to me that the remote inspector is trying to load the non-remote ui or something like that.
(In reply to comment #2) > (In reply to comment #1) > > So we fixed an early runtime error in the frontend soon after that: > > http://trac.webkit.org/changeset/181905 > > > > Can you see if this test still fails after that revision? > > Yes, remote inspector is still broken. I see a lot of js errors in the > console, like: It sounds like you're running into an early error. For instance: > TypeError: undefined is not an object (evaluating 'this.modifierKeys.altKey') This sounds like: WebInspector._updateModifierKeys = function(event) { var didChange = this.modifierKeys.altKey !== event.altKey || this.modifierKeys.metaKey !== event.metaKey || this.modifierKeys.shiftKey !== event.shiftKey; ... }; Somehow this code got called and either "this" or "this.modifierKeys" was undefined. That shouldn't happen, modifierKeys is initialized in WebInspector.contentLoaded. > TypeError: undefined is not an object (evaluating > 'WebInspector.Resizer.RuleOrientation.Vertical') This should be defined via Resizer.js. > It seems to me that the remote inspector is trying to load the non-remote ui > or something like that. - Are there earlier errors? The earliest error may give an indication as what is going on! - Are ES6 classes supported in the browser showing the remote inspector? - Maybe Symbol is not supported? Timothy Hatcher has a patch that monkey-patches that in to a degree: Adding a window.Symbol to InspectorFrontendHostStub.js I suspect it is window.Symbol issues.
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > So we fixed an early runtime error in the frontend soon after that: > > > http://trac.webkit.org/changeset/181905 > > > > > > Can you see if this test still fails after that revision? > > > > Yes, remote inspector is still broken. I see a lot of js errors in the > > console, like: > > It sounds like you're running into an early error. For instance: > > > TypeError: undefined is not an object (evaluating 'this.modifierKeys.altKey') > > This sounds like: > > WebInspector._updateModifierKeys = function(event) > { > var didChange = this.modifierKeys.altKey !== event.altKey || > this.modifierKeys.metaKey !== event.metaKey || this.modifierKeys.shiftKey > !== event.shiftKey; > ... > }; > > Somehow this code got called and either "this" or "this.modifierKeys" was > undefined. That shouldn't happen, modifierKeys is initialized in > WebInspector.contentLoaded. It's this.modifierKeys, I managed to fix this particular issue by moving the initialization of this.modifierKeys earlier in WebInspector.contentLoaded. > > > > TypeError: undefined is not an object (evaluating > > 'WebInspector.Resizer.RuleOrientation.Vertical') > > This should be defined via Resizer.js. Yes, tried something similar but it didn't work. > > > It seems to me that the remote inspector is trying to load the non-remote ui > > or something like that. > > - Are there earlier errors? The earliest error may give an indication as > what is going on! I think those were the first ones, but I'll try again. > - Are ES6 classes supported in the browser showing the remote inspector? I used the MiniBrowser for both. > - Maybe Symbol is not supported? Timothy Hatcher has a patch that > monkey-patches that in to a degree: > Adding a window.Symbol to InspectorFrontendHostStub.js > > I suspect it is window.Symbol issues. I'll try, thanks.
Created attachment 250348 [details] Screenshot showing the console errors These are the errors I'm getting
There are indeed several Can't find variable: Symbol.
Local inspector works perfectly, FWIW.
It seems this has been fixed by r182653. It was indeed the Symbol issue, thanks Joseph for your help.