RESOLVED FIXED 143021
[iOS] Remove unused keyboard code in WKSelectPopover class 
https://bugs.webkit.org/show_bug.cgi?id=143021
Summary [iOS] Remove unused keyboard code in WKSelectPopover class
Enrica Casucci
Reported 2015-03-24 14:51:18 PDT
Cleanup task.
Attachments
Patch (2.18 KB, patch)
2015-03-24 14:55 PDT, Enrica Casucci 		joepeck: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2015-03-24 14:55:34 PDT
Created attachment 249356 [details] Patch
Joseph Pecoraro
Comment 2 2015-03-24 16:22:34 PDT
Comment on attachment 249356 [details] Patch Looks good to me You can probably remove a bunch of UIKeyboard stuff from UIKitSPI.h, since I would guess this might be the only place it is used.
Enrica Casucci
Comment 3 2015-03-24 16:28:06 PDT
(In reply to comment #2) > Comment on attachment 249356 [details] > Patch > > Looks good to me > > You can probably remove a bunch of UIKeyboard stuff from UIKitSPI.h, since I > would guess this might be the only place it is used. Unfortunately the keyboard is still widely used in WKContentViewInteraction.mm Thanks for the review!
Enrica Casucci
Comment 4 2015-03-24 16:38:25 PDT
Committed revision 181919.
Note You need to log in before you can comment on or make changes to this bug.