Bug 143021 - [iOS] Remove unused keyboard code in WKSelectPopover class
Summary: [iOS] Remove unused keyboard code in WKSelectPopover class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-24 14:51 PDT by Enrica Casucci
Modified: 2015-03-24 16:38 PDT (History)
1 user (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2015-03-24 14:55 PDT, Enrica Casucci 		joepeck: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2015-03-24 14:51:18 PDT 
Cleanup task.
Comment 1 Enrica Casucci 2015-03-24 14:55:34 PDT 
Created attachment 249356 [details]
Patch
Comment 2 Joseph Pecoraro 2015-03-24 16:22:34 PDT 
Comment on attachment 249356 [details]
Patch

Looks good to me

You can probably remove a bunch of UIKeyboard stuff from UIKitSPI.h, since I would guess this might be the only place it is used.
Comment 3 Enrica Casucci 2015-03-24 16:28:06 PDT 
(In reply to comment #2)
> Comment on attachment 249356 [details]
> Patch
> 
> Looks good to me
> 
> You can probably remove a bunch of UIKeyboard stuff from UIKitSPI.h, since I
> would guess this might be the only place it is used.

Unfortunately the keyboard is still widely used in WKContentViewInteraction.mm
Thanks for the review!
Comment 4 Enrica Casucci 2015-03-24 16:38:25 PDT 
Committed revision 181919.