Bug 143018 - MediaControls: Use font with fixed number width
Summary: MediaControls: Use font with fixed number width
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-24 14:12 PDT by Dean Jackson
Modified: 2015-03-25 10:44 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.39 KB, patch)
2015-03-24 14:13 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (7.66 KB, patch)
2015-03-24 14:20 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (11.05 KB, patch)
2015-03-25 10:29 PDT, Dean Jackson
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-03-24 14:12:07 PDT
MediaControls: Use font with fixed number width
Comment 1 Dean Jackson 2015-03-24 14:12:42 PDT
<rdar://problem/20245415>
Comment 2 Dean Jackson 2015-03-24 14:13:30 PDT
Created attachment 249351 [details]
Patch
Comment 3 Dean Jackson 2015-03-24 14:13:44 PDT
WIP - not for review
Comment 4 WebKit Commit Bot 2015-03-24 14:15:36 PDT
Attachment 249351 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/spi/cocoa/CoreTextSPI.h:83:  The parameter name "options" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/mac/FontCacheMac.mm:163:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:619:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 4 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Dean Jackson 2015-03-24 14:20:10 PDT
Created attachment 249352 [details]
Patch
Comment 6 WebKit Commit Bot 2015-03-24 14:22:46 PDT
Attachment 249352 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/mac/FontCacheMac.mm:163:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:619:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 3 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Dean Jackson 2015-03-25 10:29:26 PDT
Created attachment 249411 [details]
Patch
Comment 8 Dean Jackson 2015-03-25 10:44:47 PDT
Committed r181965: <http://trac.webkit.org/changeset/181965>