Bug 143008 - Improve the offsetWidth/Height layout optimization
Summary: Improve the offsetWidth/Height layout optimization
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on: 143034
Blocks:
  Show dependency treegraph
 
Reported: 2015-03-24 10:02 PDT by Dave Hyatt
Modified: 2015-03-26 12:10 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.93 KB, patch)
2015-03-24 10:04 PDT, Dave Hyatt
dino: review+
Details | Formatted Diff | Diff
Patch (8.49 KB, patch)
2015-03-25 12:05 PDT, Dave Hyatt
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2015-03-24 10:02:34 PDT
This patch covers some improvements to the offsetWidth/Height computation for avoiding layout.
Comment 1 Dave Hyatt 2015-03-24 10:04:18 PDT
Created attachment 249333 [details]
Patch
Comment 2 WebKit Commit Bot 2015-03-24 10:05:42 PDT
Attachment 249333 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2015-03-24 12:14:07 PDT
Fixed in r181898.
Comment 4 Alexey Proskuryakov 2015-03-24 13:26:38 PDT
This broke fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html on WK1, not sure why EWS didn't notice. Maybe it fails when run with other tests, but succeeeds alone?

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fregions%2Fauto-size%2Fautoheight-two-pass-layout-complex-002.html
Comment 5 Mark Lam 2015-03-24 19:20:33 PDT
(In reply to comment #4)
> This broke
> fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html on WK1,
> not sure why EWS didn't notice. Maybe it fails when run with other tests,
> but succeeeds alone?
> 
> https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=fast%2Fregions%2Fauto-size%2Fautoheight-two-pass-
> layout-complex-002.html

r181909: <http://trac.webkit.org/changeset/181909> made it better for WK2 on Yosemite, but the test is still failing on WK1 Yosemite, and on Mavericks bots.
Comment 6 Alexey Proskuryakov 2015-03-24 20:47:29 PDT
As it still fails and Dave is not around, rolling out.
Comment 7 WebKit Commit Bot 2015-03-24 20:49:07 PDT
Re-opened since this is blocked by bug 143034
Comment 8 Dave Hyatt 2015-03-25 12:05:17 PDT
Created attachment 249421 [details]
Patch
Comment 9 Dave Hyatt 2015-03-26 12:10:15 PDT
Fixed in r182022.